OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-555-gcba5217

Gerrit Code Review gerrit@openafs.org
Fri, 7 Aug 2026 11:01:33 -0400


The following commit has been merged in the master branch:
commit cba5217cd83fcdb16c8f9bc5a7a219c3e5e0f657
Author: Andrew Deason <adeason@sinenomine.net>
Date:   Fri Jul 31 17:18:07 2026 -0500

    rxkad: Declare 'outsum' as a u_long
    
    Building src/rxkad/test/stress_c.c currently fails to build on 32-bit
    x86:
    
        stress_c.c: In function 'Copious':
        stress_c.c:171:39: error: passing argument 2 of 'EndRXKST_Copious' from incompatible pointer type [-Wincompatible-pointer-types]
          171 |         code = EndRXKST_Copious(call, &outsum);
              |                                       ^~~~~~~
              |                                       |
              |                                       size_t * {aka unsigned int *}
        In file included from stress_c.c:26:
        stress.h:100:26: note: expected 'u_long *' {aka 'long unsigned int *'} but argument is of type 'size_t *' {aka 'unsigned int *'}
          100 |         /*OUT*/ u_long * outsum);
              |                 ~~~~~~~~~^~~~~~
        make[3]: *** [.../src/config/Makefile.lwp:9: stress_c.o] Error 1
    
    Change 'outsum' to be a u_long instead of a size_t, since the output
    argument of RXKST_Copious() is defined as a u_long in the xg definition.
    
    Commit d17adc3002 (rxkad: Make the test suite build again) originally
    fixed this by changing 'outsum' from a 'long' to a 'size_t', which
    happens to be the same size and signedness on most modern platforms. But
    they are different sizes these days on some platforms, such as Debian
    i386.
    
    Change-Id: I625d7abc92fa2188411ebdf8a09da8ace0d8a6e0
    Reviewed-on: https://gerrit.openafs.org/16920
    Tested-by: BuildBot <buildbot@rampaginggeek.com>
    Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
    Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
    Reviewed-by: Gaurav Saxena <gsaxena@sinenomine.net>
    Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>

 src/rxkad/test/stress_c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
OpenAFS Master Repository