OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-518-g907dc2c
Gerrit Code Review
gerrit@openafs.org
Tue, 30 Jun 2026 15:18:16 -0400
The following commit has been merged in the master branch:
commit 907dc2c1f040fcb8b102c4221e8f252a2cc17d11
Author: Marcio Barbosa <mbarbosa@sinenomine.net>
Date: Wed Jun 24 12:37:40 2026 +0000
volser: Return EINVAL if clone ID is missing
SAFSVolClone() currently fails silently when the clone volume ID
(newNumber) is not provided. In this case, the RPC returns success
without creating a clone, which can mislead callers into believing the
operation completed successfully.
To prevent that from happening, return EINVAL when newNumber is missing.
Also move the initialization of 'error' closer to its first use so the
compiler can warn about future code paths that return before 'error' has
been assigned.
Change-Id: I3bed56c2bc1349e27e7e7986d06356dd57745ae7
Reviewed-on: https://gerrit.openafs.org/16842
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
src/volser/volprocs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
OpenAFS Master Repository