OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-786-g36f4d6f
Gerrit Code Review
gerrit@openafs.org
Mon, 9 Nov 2026 20:15:57 -0500
The following commit has been merged in the master branch:
commit 36f4d6f5f1aab5557ccb72316f6a332fcade55f6
Author: Michael Meffie <mmeffie@sinenomine.net>
Date: Thu Nov 5 05:51:20 2026 -0500
RedHat: Set the package version with spec macros
openafs.spec.in is a template rather than a valid spec file. The Version
and Release tags are set from @LINUX_PKGVER@ and @LINUX_PKGREL@
placeholders, and '@' is not allowed in either tag, so rpm tools such as
rpmspec and rpmlint cannot parse the spec until makesrpm.pl has replaced
the placeholders.
For example:
$ rpmspec -P openafs.spec.in
error: line 245: Illegal char '@' (0x40) in: Version: @LINUX_PKGVER@
Replace the placeholders with the openafs_version, package_version, and
package_release macros. Each is set with %global unless already defined,
so the spec is valid as it is and can be used without makesrpm.pl, with
the version given with rpmbuild --define. Rename the afsvers, pkgvers,
and pkgrel macros to match.
makesrpm.pl now sets these %global lines in the spec file it generates.
It keeps the old substitutions, since it is also used to build source
RPMs from older source releases.
Assisted-by: Claude:claude-opus-5-5
Change-Id: I77b0f514961afff2c310568d13f0328771d06dbb
Reviewed-on: https://gerrit.openafs.org/17220
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
src/packaging/RedHat/makesrpm.pl | 5 ++-
src/packaging/RedHat/openafs.spec.in | 65 ++++++++++++++++++++++++------------
2 files changed, 47 insertions(+), 23 deletions(-)
--
OpenAFS Master Repository