OpenAFS Master Repository branch, openafs-stable-1_8_x, updated. openafs-stable-1_8_16_1-16-g4680045
Gerrit Code Review
gerrit@openafs.org
Thu, 8 Oct 2026 11:37:55 -0400
The following commit has been merged in the openafs-stable-1_8_x branch:
commit 4680045b6149cf1d71d529c9be05d29a75a47009
Author: Andrew Deason <adeason@sinenomine.net>
Date: Tue Sep 15 14:47:50 2026 -0500
WINNT: Remove strcpy() in ktc_ForgetTokensByCell()
Since OpenAFS 1.0, ktc_ForgetTokensByCell() (then ktc_ForgetToken()) has
strcpy()d the cell from the provided arguments into the stack-local
"tbuffer" before passing the cell to the VIOCDELTOK pioctl.
There's no reason to use an intermediate stack buffer; just pass the
given string pointer directly to the pioctl, so we don't risk
overrunning the "tbuffer" with an unsafe strcpy() call.
Reviewed-on: https://gerrit.openafs.org/16976
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 151ed20e14eb0a22140190c2ad0c4548c6927a5d)
Change-Id: I10ae0ad24d19e1f8c7c3043de199878e02fee630
Reviewed-on: https://gerrit.openafs.org/17006
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/auth/ktc_nt.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
--
OpenAFS Master Repository