OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-649-gb9a70f6
Gerrit Code Review
gerrit@openafs.org
Tue, 20 Oct 2026 15:36:33 -0400
The following commit has been merged in the master branch:
commit b9a70f6e95bf3330a32a433295cf90a02ed3410a
Author: Andrew Deason <adeason@sinenomine.net>
Date: Fri Oct 16 12:42:04 2026 -0500
ptserver: Set non-NULL trans in ptubik.c
The ubik stub implementation ptubik.c doesn't use any information in
struct ubik_trans, so our stub ubik_BeginTrans() never sets a
transaction pointer, and so the transaction provided to many functions
is NULL.
This works, but it makes it difficult for ubik code to perform safety
checks if a transaction pointer is valid; if we throw an error on a NULL
transaction, we'll accidentally trigger on a "valid" transaction when
using ptubik.c. Currently, no code does this, but future commits may do
so.
To get around this, change the ubik_BeginTrans*() functions in ptubik.c
to set a "dummy" transaction pointer. We still never look at the
provided transactions, but at least we set it to a non-NULL pointer now.
Change-Id: Iec1d8fad9e42786f368c470497b237d0f974d06a
Reviewed-on: https://gerrit.openafs.org/17047
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
src/ptserver/ptubik.c | 7 +++++++
1 file changed, 7 insertions(+)
--
OpenAFS Master Repository