OpenAFS Master Repository branch, master, updated. openafs-devel-1_9_2-591-g151ed20
Gerrit Code Review
gerrit@openafs.org
Thu, 17 Sep 2026 16:16:17 -0400
The following commit has been merged in the master branch:
commit 151ed20e14eb0a22140190c2ad0c4548c6927a5d
Author: Andrew Deason <adeason@sinenomine.net>
Date: Tue Sep 15 14:47:50 2026 -0500
WINNT: Remove strcpy() in ktc_ForgetTokensByCell()
Since OpenAFS 1.0, ktc_ForgetTokensByCell() (then ktc_ForgetToken()) has
strcpy()d the cell from the provided arguments into the stack-local
"tbuffer" before passing the cell to the VIOCDELTOK pioctl.
There's no reason to use an intermediate stack buffer; just pass the
given string pointer directly to the pioctl, so we don't risk
overrunning the "tbuffer" with an unsafe strcpy() call.
Change-Id: I9e379b63769028717ae0ec1825c917f1bb7ab19f
Reviewed-on: https://gerrit.openafs.org/16976
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
src/auth/ktc_nt.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
--
OpenAFS Master Repository