[OpenAFS-devel] Error diagnosis - ReallyRead failure

Neulinger, Nathan nneul@umr.edu
Tue, 12 Feb 2002 12:30:39 -0600


just sent a patch for the ones in viced, have not checked over all the
instances elsewhere in src yet.

-- Nathan

------------------------------------------------------------
Nathan Neulinger                       EMail:  nneul@umr.edu
University of Missouri - Rolla         Phone: (573) 341-4841
Computing Services                       Fax: (573) 341-4216


> -----Original Message-----
> From: Ted Anderson [mailto:ota@transarc.com]=20
> Sent: Tuesday, February 12, 2002 9:13 AM
> To: openafs-devel@openafs.org; Neulinger, Nathan
> Subject: Re: [OpenAFS-devel] Error diagnosis - ReallyRead failure
>=20
>=20
> The problem is that that these print statements are in error.  They
> contain a %X but are passed a (pointer to) a string representation of
> the inode value.
>=20
> From viced/physio.c:82:
>         ViceLog (0,
> 		 ("ReallyRead(): read failed device %X inode %X=20
> errno %d\n",
> 		  file->dirh_handle->ih_dev,
> 		  PrintInode(NULL, file->dirh_handle->ih_ino), code));
> Where PrintInode is defined in  sys/afssyscalls.h as:
>     extern char *PrintInode(afs_ino_str_t, Inode);
>=20
> So the (second) %X needs to be turned into a %s.  A quick scan of
> src/viced turns up several more of these.
>=20
> Ted Anderson
>=20