[OpenAFS-devel] RX_ENABLE_LOCKS and AFS_GLOCK()

[Neulinger, Nathan]

Cool. Yeah, that'll clean the code in afs/ up nicely.=20

-- Nathan

------------------------------------------------------------
Nathan Neulinger                       EMail:  nneul@umr.edu
University of Missouri - Rolla         Phone: (573) 341-4841
Computing Services                       Fax: (573) 341-4216


> -----Original Message-----
> From: Nickolai Zeldovich [mailto:kolya@MIT.EDU]=20
> Sent: Wednesday, February 13, 2002 2:11 PM
> To: Neulinger, Nathan
> Cc: openafs-devel@openafs.org
> Subject: Re: [OpenAFS-devel] RX_ENABLE_LOCKS and AFS_GLOCK()
>=20
>=20
> > Is it really necessary to have AFS_GLOCK()/GUNLOCK() wrapped with an
> > #ifdef RX_ENABLE_LOCKS everywhere in the source? It appears that the
> > definitions of those macros are #ifdef'd already. Seems=20
> like it would
> > clean up the code quite a bit to get rid of all the=20
> spurious ifdef's.=20
>=20
> There's RX_AFS_GLOCK() and RX_AFS_GUNLOCK() in the mainline (which
> I snuck in with the dcache locking changes), which are defined to
> be AFS_GLOCK/AFS_GUNLOCK when RX_ENABLE_LOCKS is set, and blank
> otherwise.  So, you can replace the #ifdef/AFS_GLOCK/#endif combo
> with RX_AFS_GLOCK, etc, if you want.
>=20
> -- kolya
>=20