[OpenAFS-devel] stddef.h doesn't belong in the kernel

Jim Rees rees@umich.edu
Tue, 01 Oct 2002 16:14:38 -0400


I had to apply the following diff for the OpenBSD port.  As far as I know,
stddef.h should never be used in the kernel, so would it make sense to do
this for all architectures?  Or are there some that need it?

% cvs diff -u util/afs_lhash.h util/afs_atomlist.h
Index: util/afs_lhash.h
===================================================================
RCS file: /cvs/openafs/src/util/afs_lhash.h,v
retrieving revision 1.2
diff -u -r1.2 afs_lhash.h
--- util/afs_lhash.h    2000/11/04 10:06:02     1.2
+++ util/afs_lhash.h    2002/10/01 20:11:17
@@ -28,7 +28,9 @@
 #ifndef AFS_LHASH_H
 #define AFS_LHASH_H
 
+#ifndef KERNEL
 #include <stddef.h>
+#endif
 
 /*
  * The user is responsible for generating the key values corresponding
Index: util/afs_atomlist.h
===================================================================
RCS file: /cvs/openafs/src/util/afs_atomlist.h,v
retrieving revision 1.2
diff -u -r1.2 afs_atomlist.h
--- util/afs_atomlist.h 2000/11/04 10:06:02     1.2
+++ util/afs_atomlist.h 2002/10/01 20:11:17
@@ -28,7 +28,9 @@
 #ifndef ATOMLIST_H
 #define ATOMLIST_H
 
+#ifndef KERNEL
 #include <stddef.h>
+#endif
 
 typedef struct afs_atomlist afs_atomlist;