[OpenAFS-devel] comment on applied kauth/user_nt.c patch

[Jeffrey Altman]

This is a cryptographically signed message in MIME format.

--------------ms090602060305040902000502
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

This is a windows specific file.  The type of SOCKET is Unsigned Int on 
all platforms.
This is safe.



Joe Buehler wrote:

> Looking at the current CVS, I see that the following snippet
> in kauth/user_nt.c is still incorrect:
>
>     if (krb_debug) {
>         fprintf(stderr, "select failed: readfds=%p", readfds);
>         perror("");
>     }
>
> I had submitted a patch containing a comment about the format
> being incorrect.  I should have been less terse -- the problem is that
> readfds may have a non-integral type.  It is a set of file descriptors,
> so it might actually be an array or a struct.  The format was originally
> %x, which will work for integer "readfds".  But for RedHat 9, for 
> example,
> readfds is actually a struct containing an array of 32 or so longs.


--------------ms090602060305040902000502
Content-Type: application/x-pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKtDCC
A4IwggJqAgIArjANBgkqhkiG9w0BAQQFADBWMQswCQYDVQQGEwJVUzERMA8GA1UECBMITmV3
IFlvcmsxNDAyBgNVBAoTK0NvbHVtYmlhIFVuaXZlcnNpdHkgaW4gdGhlIENpdHkgb2YgTmV3
IFlvcmswHhcNMDMwNDE0MTMzMDQ1WhcNMDQwNDEzMTMzMDQ1WjCBtjELMAkGA1UEBhMCVVMx
ETAPBgNVBAgTCE5ldyBZb3JrMRYwFAYDVQQHEw1OZXcgWW9yayBDaXR5MRwwGgYDVQQKExND
b2x1bWJpYSBVbml2ZXJzaXR5MRswGQYDVQQLExJUaGUgS2VybWl0IFByb2plY3QxHDAaBgNV
BAMTE0plZmZyZXkgRXJpYyBBbHRtYW4xIzAhBgkqhkiG9w0BCQEWFGphbHRtYW5AY29sdW1i
aWEuZWR1MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA3BqDkjprtbUObzZi0+Ot
q4+8AZD9Mq+LMM/0YuroyVd/AKr0VqA0W2zs1ntLCVXJ+D1WcCU5unLWwSrXislCPcHB9dhK
MjoUICqVYU2YH/4YtqlQl8EpYMlAv7s6aK1Zk1Sx3WrwuSuc112+dIeubzDfiGwwMbKxuySl
Q4F+YTTEVd+VQjb08hkbf+W5aXqFQHdrVz/0LQ0jYwud6a3TWEtPSyW9AVQNn7dHozVcxVqW
9VA0f8tOM3xmCyX+6Fs6660rITBm7Zh6POEUNWw7qI7f1WiCojMpiLafRdwlK4xaaW855DSU
ZcUtjWecZvpWzwQLywD4lZuKFjIuINfPjQIDAQABMA0GCSqGSIb3DQEBBAUAA4IBAQCPFBeK
geiYWaMtIPgQB4lOcaGywbkI3NzfBibtD1oOm2dg/t8aUsQOkN+gccnR6vHOrHf7TCTa+8bn
HrhQwKiMz6cDxvWxktNDL2Jn9v/dcEaT2bIU1lgA9B7OddtLqUOq+DiBA/0VcLYfSNk9foza
clYQvdL90nKaK+VLXieSpPIrRBZEXp4y6FfyeQQSpE8mgZfQDM7mnlpKNhjk54V1TbZlz3yI
r/AexQLix2dWPSlFijHV3SNwUelDpnviBozlN758ZIM87eAZuGppOkwyLqRJ6hmxdxuVKuom
sg0apswhKEuJ4NnygGnxrf5LJUKTzf1yb5f6pZYuz6r8Tuf6MIIDgjCCAmoCAgCuMA0GCSqG
SIb3DQEBBAUAMFYxCzAJBgNVBAYTAlVTMREwDwYDVQQIEwhOZXcgWW9yazE0MDIGA1UEChMr
Q29sdW1iaWEgVW5pdmVyc2l0eSBpbiB0aGUgQ2l0eSBvZiBOZXcgWW9yazAeFw0wMzA0MTQx
MzMwNDVaFw0wNDA0MTMxMzMwNDVaMIG2MQswCQYDVQQGEwJVUzERMA8GA1UECBMITmV3IFlv
cmsxFjAUBgNVBAcTDU5ldyBZb3JrIENpdHkxHDAaBgNVBAoTE0NvbHVtYmlhIFVuaXZlcnNp
dHkxGzAZBgNVBAsTElRoZSBLZXJtaXQgUHJvamVjdDEcMBoGA1UEAxMTSmVmZnJleSBFcmlj
IEFsdG1hbjEjMCEGCSqGSIb3DQEJARYUamFsdG1hbkBjb2x1bWJpYS5lZHUwggEiMA0GCSqG
SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDcGoOSOmu1tQ5vNmLT462rj7wBkP0yr4swz/Ri6ujJ
V38AqvRWoDRbbOzWe0sJVcn4PVZwJTm6ctbBKteKyUI9wcH12EoyOhQgKpVhTZgf/hi2qVCX
wSlgyUC/uzporVmTVLHdavC5K5zXXb50h65vMN+IbDAxsrG7JKVDgX5hNMRV35VCNvTyGRt/
5blpeoVAd2tXP/QtDSNjC53prdNYS09LJb0BVA2ft0ejNVzFWpb1UDR/y04zfGYLJf7oWzrr
rSshMGbtmHo84RQ1bDuojt/VaIKiMymItp9F3CUrjFppbznkNJRlxS2NZ5xm+lbPBAvLAPiV
m4oWMi4g18+NAgMBAAEwDQYJKoZIhvcNAQEEBQADggEBAI8UF4qB6JhZoy0g+BAHiU5xobLB
uQjc3N8GJu0PWg6bZ2D+3xpSxA6Q36BxydHq8c6sd/tMJNr7xuceuFDAqIzPpwPG9bGS00Mv
Ymf2/91wRpPZshTWWAD0Hs5120upQ6r4OIED/RVwth9I2T1+jNpyVhC90v3Scpor5UteJ5Kk
8itEFkRenjLoV/J5BBKkTyaBl9AMzuaeWko2GOTnhXVNtmXPfIiv8B7FAuLHZ1Y9KUWKMdXd
I3BR6UOme+IGjOU3vnxkgzzt4Bm4amk6TDIupEnqGbF3G5Uq6iayDRqmzCEoS4ng2fKAafGt
/kslQpPN/XJvl/qlli7PqvxO5/owggOkMIICjKADAgECAgUEYAAADTANBgkqhkiG9w0BAQQF
ADB0MQswCQYDVQQGEwJVUzE6MDgGA1UEChMxQ1JFTi9Db3JwIGZvciBSZXNlYXJjaCBhbmQg
RWR1Y2F0aW9uYWwgTmV0d29ya2luZzEpMCcGA1UECxMgRWR1Y2F0aW9uIGFuZCBSZXNlYXJj
aCBDbGllbnQgQ0EwHhcNMDIwMjEzMjIzNDI5WhcNMDcwMjEyMjIzNDI5WjBWMQswCQYDVQQG
EwJVUzERMA8GA1UECBMITmV3IFlvcmsxNDAyBgNVBAoTK0NvbHVtYmlhIFVuaXZlcnNpdHkg
aW4gdGhlIENpdHkgb2YgTmV3IFlvcmswggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIB
AQDQC7w6HbOh9Kn2ud3R0u/Lp0TBaNCFJ5PHY6SvGKzpc/y0+rV3N6SL7V1RAHLFgcVdUCkl
XPanjqKdYqjMJsRx3U/kFFkvW+iCIsSUjR23IldzUpo+30hUCBTLW4EqMNjBKQZRCNjs9QlW
GBWE0y9Chhms6lHZJegG6YULe+EKqU2bEa7Zq2xuRj9EpstkbpUsM5wb7zCFmw28Cly8VgOC
8yIU01sIj+91vYsujH+CLgVLUG0D8kr4sbXr+Uk8/d05LpM+iKbRMOEUQPEYHJw/mwXF81/c
DCXZnaH3B8ZhFjR0tbk4JecCDfuZ0jnf8HC13PpUHc46RGx5BNK3fUQ/AgMBAAGjWzBZMAwG
A1UdEwQFMAMBAf8wHQYDVR0OBBYEFLHbwnjjGeFj8sj00g//ulw1DII0MB0GA1UdIwQWBBSZ
XFkzrbStei+68QrYZGLNXx9BeTALBgNVHQ8EBAMCAAYwDQYJKoZIhvcNAQEEBQADggEBAI2U
gdjA0FQNBDrGe+6MPDaOpPxY+UeT1/ZAmP7QovRDUC8csGZblO0OBq+XlFaxm0ABgqnu+MkE
9cKikfNH1c61zE9PYD5Kj67u359KhfQPHEoBOxO2t6gAg9AS1Y9nuUK+i90W9x8irA9U6Gar
4rmaLTIl1p+lWjdmLsGd+kywTb3u5zU+BgC0bsMQkwAr2nBjnN0woi23y7LNXkiAWrj9f4VP
VLgJBshItbUC6AdNbFhYrKSeA8vaYdMX1z7ZwKs/1IxKNQoV/Du/InzvJgwbN5XCckdQ5G5F
/QPbf7nSviQmhDMHNn8ty4uBk9Ss5rpftGrOFx0V/EaNpmn8yRQxggMUMIIDEAIBATBcMFYx
CzAJBgNVBAYTAlVTMREwDwYDVQQIEwhOZXcgWW9yazE0MDIGA1UEChMrQ29sdW1iaWEgVW5p
dmVyc2l0eSBpbiB0aGUgQ2l0eSBvZiBOZXcgWW9yawICAK4wCQYFKw4DAhoFAKCCAY0wGAYJ
KoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMDMxMjAyMjIxODEwWjAj
BgkqhkiG9w0BCQQxFgQUTMOtQYArEZgSrvmxk93Y5oj2v+UwUgYJKoZIhvcNAQkPMUUwQzAK
BggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYI
KoZIhvcNAwICASgwawYJKwYBBAGCNxAEMV4wXDBWMQswCQYDVQQGEwJVUzERMA8GA1UECBMI
TmV3IFlvcmsxNDAyBgNVBAoTK0NvbHVtYmlhIFVuaXZlcnNpdHkgaW4gdGhlIENpdHkgb2Yg
TmV3IFlvcmsCAgCuMG0GCyqGSIb3DQEJEAILMV6gXDBWMQswCQYDVQQGEwJVUzERMA8GA1UE
CBMITmV3IFlvcmsxNDAyBgNVBAoTK0NvbHVtYmlhIFVuaXZlcnNpdHkgaW4gdGhlIENpdHkg
b2YgTmV3IFlvcmsCAgCuMA0GCSqGSIb3DQEBAQUABIIBAAqnGD3EYyuVVEeN/5qoGY0puwjW
19vA562seSESeqV0N/Q/bfsS0QIEKBF0nHV+9twimQn1V+8maCDJU9Jx73QoVn5jmjUf089t
d46u4F4RteX9TETBprSgAPjYi8PnZKTEMsGIEgf77C8hlSsCyd/opX+uqvAjOmIKuuWKx3Wl
U3/UCY4Guj8fEeGiyVRrYt83fDNn103c9eAYI00cV8egVbIrChkwNGsw0RvQRipn/Ldlf/Pz
2vROQ1xH1BUuuYk3r1E6PvXb/orXCDVQBtQ/rQwjUHX3FQQKM0tStp0J4/icYm+o7BNNFPT2
1XUw6vinPKYTvPrWOYP2OxIGLkQAAAAAAAA=
--------------ms090602060305040902000502--