[OpenAFS-devel] Windows crash and other problems associated with GetToken

James Peterson james@abrakus.com
Sat, 8 Feb 2003 14:35:17 -0800


The following patch was discovered while looking into Windows AFS crashes.
At least this will help the client from crashing when multiple tokens are
involved.

diff -NurEB --exclude-from=exclude bas/src/WINNT/afsd/cm_rpc.c
upd/src/WINNT/afsd/cm_rpc.c
--- bas/src/WINNT/afsd/cm_rpc.c	2001-04-30 00:48:06.000000000 -0700
+++ upd/src/WINNT/afsd/cm_rpc.c	2003-02-08 14:31:07.000000000 -0800
@@ -82,12 +82,14 @@
 	ltep = &tokenEvents;
 	while (te) {
 		if (UuidEqual((UUID *)&uuid, (UUID *)&te->uuid, &status))
+		{
 			*ltep = te->next;
 			lock_ReleaseMutex(&tokenEventLock);
 			memcpy(sessionKey, te->sessionKey,
 				sizeof(te->sessionKey));
 			free(te);
 			return TRUE;
+		}
 		ltep = &te->next;
 		te = te->next;
 	}

Sorry I can't take credit for the discovery; however, it should help out
those with similar problems.

James
"Integrity is the Base of Excellence"