[OpenAFS-devel] kernel panic running iozone under Mac OS X

Edward Moy emoy@apple.com
Wed, 29 Jan 2003 13:28:53 -0800


You are the MAN!  Not only did this fix the panic, but iozone finished 
in 36 minutes (instead of 3 1/2 hours and then panicing).

Many thanks,

Edward Moy
Apple Computer, Inc.
emoy@apple.com

(This message is from me as a reader of this list, and not a statement
from Apple.)

On Wednesday, January 29, 2003, at 10:30  AM, Jim Rees wrote:

> This is even more conservative:
>
> Index: DARWIN/rx_knet.c
> ===================================================================
> RCS file: /cvs/openafs/src/rx/DARWIN/rx_knet.c,v
> retrieving revision 1.8
> diff -u -r1.8 rx_knet.c
> --- DARWIN/rx_knet.c	16 Oct 2002 03:58:52 -0000	1.8
> +++ DARWIN/rx_knet.c	29 Jan 2003 18:29:36 -0000
> @@ -21,7 +21,7 @@
>      struct uio u;
>      int i;
>      struct iovec iov[RX_MAXIOVECS];
> -    struct sockaddr *sa;
> +    struct sockaddr *sa = NULL;
>      int code;
>
>      int haveGlock = ISAFS_GLOCK();
> @@ -57,13 +57,16 @@
>      if (haveGlock) {
>          AFS_GLOCK();
>      }
> -    *alength=*alength-u.uio_resid;
> +    if (code)
> +	return code;
> +    *alength -= u.uio_resid;
>      if (sa) {
>         if (sa->sa_family == AF_INET) {
>            if (addr) *addr=*(struct sockaddr_in *)sa;
>         } else {
>            printf("Unknown socket family %d in NetReceive\n");
>         }
> +       FREE(sa, M_SONAME);
>      }
>      return code;
>  }