[OpenAFS-devel] [PATCH] flexelint: remove unused global declarations

Joe Buehler jbuehler@hekimian.com
Fri, 21 Nov 2003 14:21:42 -0500


This is a multi-part message in MIME format.
--------------000509040104010503090302
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

This patch removes a slew of global declarations that are not needed.

A subsequent patch with further changes to global prototypes
will be posted shortly.
-- 
Joe Buehler


--------------000509040104010503090302
Content-Type: text/plain;
 name="temp.patch.duplicate-declaration"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="temp.patch.duplicate-declaration"

--- ./src/WINNT/afsadmsvr/TaAfsAdmSvrMain.cpp.~1~	2000-11-04 05:01:16.000000000 -0500
+++ ./src/WINNT/afsadmsvr/TaAfsAdmSvrMain.cpp	2003-11-20 14:39:55.000000000 -0500
@@ -14,16 +14,6 @@
 
 #include "TaAfsAdmSvrInternal.h"
 
-
-/*
- * DEFINITIONS ________________________________________________________________
- *
- */
-
-extern void AfsAdmSvr_Startup (void);
-extern void AfsAdmSvr_Shutdown (void);
-
-
 /*
  * ROUTINES ___________________________________________________________________
  *
--- ./src/WINNT/afsclass/worker.cpp.~1~	2000-11-06 10:49:06.000000000 -0500
+++ ./src/WINNT/afsclass/worker.cpp	2003-11-20 16:10:11.000000000 -0500
@@ -373,13 +373,9 @@
  *
  */
 
-BOOL Worker_StartOneThread (BOOL fActivate, ULONG *pStatus = NULL);
-
 BOOL Worker_LoadLibraries (ULONG *pStatus);
 void Worker_FreeLibraries (void);
 
-DWORD _stdcall Worker_ThreadProc (LPARAM lp);
-
 DWORD Worker_PerformTask (WORKERTASK wtask, LPWORKERPACKET lpwp);
 
 
--- ./src/WINNT/afsd/afsd_init.c.~1~	2003-06-06 17:11:25.000000000 -0400
+++ ./src/WINNT/afsd/afsd_init.c	2003-11-20 13:25:15.000000000 -0500
@@ -93,8 +93,6 @@
 extern int cm_freelanceEnabled;
 #endif*/
 
-void cm_InitFakeRootDir();
-
 void
 afsi_start()
 {
--- ./src/WINNT/afsd/afsd_service.c.~1~	2003-08-25 14:24:22.000000000 -0400
+++ ./src/WINNT/afsd/afsd_service.c	2003-11-20 14:40:16.000000000 -0500
@@ -27,8 +27,6 @@
 
 extern void afsi_log(char *pattern, ...);
 
-extern char AFSConfigKeyName[];
-
 HANDLE WaitToTerminate;
 
 int GlobalStatus;
--- ./src/WINNT/afsd/cm_ioctl.c.~1~	2003-03-14 15:07:45.000000000 -0500
+++ ./src/WINNT/afsd/cm_ioctl.c	2003-11-20 13:26:33.000000000 -0500
@@ -44,9 +44,6 @@
 #define MAX_PATH 260
 
 osi_mutex_t cm_Afsdsbmt_Lock;
-#ifdef AFS_FREELANCE_CLIENT
-extern osi_mutex_t cm_Freelance_Lock;
-#endif
 
 extern afs_int32 cryptall;
 
--- ./src/WINNT/afsd/smb3.c.~1~	2003-07-10 22:12:46.000000000 -0400
+++ ./src/WINNT/afsd/smb3.c	2003-11-20 14:14:12.000000000 -0500
@@ -27,8 +27,6 @@
 
 #include "smb.h"
 
-extern smb_vc_t *dead_vcp;
-
 extern osi_hyper_t hzero;
 
 smb_packet_t *smb_Directory_Watches = NULL;
--- ./src/WINNT/afsd/smb_ioctl.c.~1~	2003-03-14 15:07:46.000000000 -0500
+++ ./src/WINNT/afsd/smb_ioctl.c	2003-11-20 13:26:21.000000000 -0500
@@ -28,7 +28,6 @@
 smb_ioctlProc_t *smb_ioctlProcsp[SMB_IOCTL_MAXPROCS];
 
 /*extern unsigned char smb_LANadapter;*/
-extern LANA_ENUM lana_list;
 
 void smb_InitIoctl(void)
 {
--- ./src/WINNT/afssvrcfg/config_server_page.cpp.~1~	2000-11-04 05:01:50.000000000 -0500
+++ ./src/WINNT/afssvrcfg/config_server_page.cpp	2003-11-20 14:12:15.000000000 -0500
@@ -85,11 +85,8 @@
 static void UpdateConfigProgress(int nStepNum);
 static void ShowTitle();
 static void ViewLog();
-static void LogConfigState();
 static void ShowConfigFailedMsg();
 static BOOL Unconfiguring();
-static void SetButtonText(UINT uiMsgID);
-static char *GetAfsRootDir();
 static BOOL GetCellServDB(char **ppszCellServDB);
 static BOOL FreeCellServDB();
 static char *GetVicepName();
--- ./src/WINNT/afssvrcfg/get_cur_config.cpp.~1~	2000-11-04 05:01:51.000000000 -0500
+++ ./src/WINNT/afssvrcfg/get_cur_config.cpp	2003-11-20 14:12:34.000000000 -0500
@@ -44,7 +44,6 @@
  */
 BOOL CALLBACK GetCurConfigDlgProc(HWND hwndDlg, UINT msg, WPARAM wp, LPARAM lp);
 static DWORD CALLBACK GetCurrentConfigState(LPPROGRESSDISPLAY ppd, LPARAM lp);
-static void SetConfigDefaults();
 static void ShowMsg(UINT uiMsgID);
 static void NextStep(UINT uiMsgID);
 
--- ./src/WINNT/afssvrcfg/partitions_page.cpp.~1~	2000-11-04 05:01:53.000000000 -0500
+++ ./src/WINNT/afssvrcfg/partitions_page.cpp	2003-11-20 14:11:19.000000000 -0500
@@ -44,7 +44,6 @@
 static TCHAR szNo[cchRESOURCE];
 
 static const UINT DISK_DRIVE_IMAGE = 0;
-static const UINT DISABLED_DISK_DRIVE_IMAGE = 1;
 
 // Remember the config state of the FS so we can detect when it changes.
 // When it changes we must redisplay the partition info.
--- ./src/WINNT/afssvrcfg/salvage_dlg.cpp.~1~	2000-11-04 05:01:53.000000000 -0500
+++ ./src/WINNT/afssvrcfg/salvage_dlg.cpp	2003-11-20 14:13:06.000000000 -0500
@@ -50,7 +50,6 @@
  *
  */
 static void OnInitDialog(HWND hwndDlg);
-static void CheckEnableButtons();
 static void OnAdvanced();
 static void UpdateControls();
 static BOOL OnSalvage();
--- ./src/WINNT/afssvrcfg/validation.cpp.~1~	2000-11-04 05:01:54.000000000 -0500
+++ ./src/WINNT/afssvrcfg/validation.cpp	2003-11-20 16:38:32.000000000 -0500
@@ -26,15 +26,11 @@
  * PROTOTYPES _________________________________________________________________
  *
  */
-BOOL Validation_IsValid(TCHAR *pszInput, VALIDATION_TYPE type, BOOL bShowError);
-
 static BOOL CheckAfsPartitionName(TCHAR *pszInput, int &nErrorMsgResID);
 static BOOL CheckAfsCellName(TCHAR *pszInput, int &nErrorMsgResID);
 static BOOL CheckAfsPassword(TCHAR *pszInput, int &nErrorMsgResID);
 static BOOL CheckAfsUid(TCHAR *pszInput, int &nErrorMsgResID);
 static BOOL CheckAfsServerName(TCHAR *pszInput, int &nErrorMsgResID);
-static BOOL CheckFileName(TCHAR *pszInput, int &nErrorMsgResID);
-static BOOL CheckPath(TCHAR *pszInput, int &nErrorMsgResID);
 static void ShowError(int nErrorMsgResID);
 
 
--- ./src/WINNT/afssvrcfg/volume_utils.cpp.~1~	2000-11-04 05:01:54.000000000 -0500
+++ ./src/WINNT/afssvrcfg/volume_utils.cpp	2003-11-20 13:24:54.000000000 -0500
@@ -29,7 +29,6 @@
  */
 static HWND m_hDriveList = 0;
 
-static const UINT MAX_DRIVES = 26;
 static const UINT DISK_DRIVE_IMAGE = 0;
 static const UINT DISABLED_DISK_DRIVE_IMAGE = 1;
 static const UINT DISK_DRIVE_WITH_WARNING_IMAGE = 2;
--- ./src/WINNT/afssvrmgr/task.cpp.~1~	2000-11-04 05:02:15.000000000 -0500
+++ ./src/WINNT/afssvrmgr/task.cpp	2003-11-20 13:21:55.000000000 -0500
@@ -81,10 +81,6 @@
  *
  */
 
-DWORD WINAPI Task_ThreadProc (PVOID lp);
-
-void Task_Perform (LPTASKPACKET ptp);
-
 #ifdef DEBUG
 void Task_ExportCell (LPTASKPACKET ptp);
 #endif
--- ./src/WINNT/afssvrmgr/window.cpp.~1~	2000-11-04 05:02:16.000000000 -0500
+++ ./src/WINNT/afssvrmgr/window.cpp	2003-11-20 21:40:22.000000000 -0500
@@ -100,9 +100,7 @@
 void Main_OnNotifyFromDispatch (LPNOTIFYSTRUCT lpns);
 
 void Main_OnPreviewPane (BOOL fPreviewNew, BOOL fVertNew, BOOL fStoreView);
-void Main_OnServerView (int lvsNew);
 DWORD WINAPI Main_OnOpenServers_ThreadProc (PVOID lp);
-void Main_OnEndTask_Properties (LPTASKPACKET ptp);
 
 void Main_SubclassServers (HWND hDlg);
 
--- ./src/WINNT/afsusrmgr/mch_delete.cpp.~1~	2000-11-04 05:02:28.000000000 -0500
+++ ./src/WINNT/afsusrmgr/mch_delete.cpp	2003-11-20 14:04:11.000000000 -0500
@@ -30,7 +30,6 @@
 BOOL CALLBACK Machine_Delete_DlgProc (HWND hDlg, UINT msg, WPARAM wp, LPARAM lp);
 void Machine_Delete_OnInitDialog (HWND hDlg);
 void Machine_Delete_OnDestroy (HWND hDlg);
-void Machine_Delete_OnCheck (HWND hDlg);
 void Machine_Delete_OnOK (HWND hDlg);
 
 
--- ./src/WINNT/afsusrmgr/task.cpp.~1~	2000-11-04 05:02:29.000000000 -0500
+++ ./src/WINNT/afsusrmgr/task.cpp	2003-11-20 13:21:43.000000000 -0500
@@ -33,10 +33,6 @@
  *
  */
 
-DWORD WINAPI Task_ThreadProc (PVOID lp);
-
-void Task_Perform (LPTASKPACKET ptp);
-
 void Task_OpenCell (LPTASKPACKET ptp);
 void Task_UpdCreds (LPTASKPACKET ptp);
 void Task_UpdUsers (LPTASKPACKET ptp);
--- ./src/WINNT/client_creds/main.cpp.~1~	2002-01-08 15:44:41.000000000 -0500
+++ ./src/WINNT/client_creds/main.cpp	2003-11-20 14:40:27.000000000 -0500
@@ -43,7 +43,6 @@
 
 BOOL InitApp (LPSTR pszCmdLineA);
 void ExitApp (void);
-void Quit (void);
 void PumpMessage (MSG *pmsg);
 BOOL IsServerInstalled (void);
 
--- ./src/bozo/bos.c.~1~	2003-08-08 16:27:58.000000000 -0400
+++ ./src/bozo/bos.c	2003-11-20 14:34:53.000000000 -0500
@@ -47,13 +47,6 @@
 #include <ubik.h>
 #include <afs/ktime.h>
 
-
-
-extern char *volutil_PartitionName();
-extern struct rx_call *rx_NewCall();
-extern char *volutil_PartitionName();
-extern struct hostent *hostutil_GetHostByName();
-
 static IStatServer();
 static DoStat();
 
--- ./src/bozo/bosoprocs.c.~1~	2003-10-24 02:31:49.000000000 -0400
+++ ./src/bozo/bosoprocs.c	2003-11-20 13:14:51.000000000 -0500
@@ -53,7 +53,6 @@
 extern struct ktime bozo_nextRestartKT, bozo_nextDayKT;
 
 extern struct afsconf_dir *bozo_confdir;
-extern struct rx_securityClass *bozo_rxsc[2];
 extern int bozo_newKTs;
 extern int DoLogging;
 #ifdef BOS_RESTRICTED_MODE
--- ./src/bozo/bosserver.c.~1~	2003-08-08 17:54:36.000000000 -0400
+++ ./src/bozo/bosserver.c	2003-11-20 14:34:38.000000000 -0500
@@ -51,7 +51,6 @@
 #define BOZO_LWP_STACKSIZE	16000
 extern int BOZO_ExecuteRequest();
 extern int RXSTATS_ExecuteRequest();
-extern int afsconf_GetKey();
 extern struct bnode_ops fsbnode_ops, ezbnode_ops, cronbnode_ops;
 
 void bozo_Log();
--- ./src/bozo/bosserver.c.~1~	2003-08-08 17:54:36.000000000 -0400
+++ ./src/bozo/bosserver.c	2003-11-20 14:34:38.000000000 -0500
@@ -61,7 +60,6 @@
 struct rx_securityClass *bozo_rxsc[3];
 const char *bozo_fileName;
 FILE *bozo_logFile;
-extern int rx_stackSize;	/* for rx_SetStackSize macro */
 
 int DoLogging = 0;
 int DoSyslog = 0;
--- ./src/bozo/cronbnodeops.c.~1~	2003-07-15 19:14:43.000000000 -0400
+++ ./src/bozo/cronbnodeops.c	2003-11-20 14:34:41.000000000 -0500
@@ -41,7 +41,6 @@
 static int cron_procexit(), cron_getstring(), cron_getparm(), cron_restartp();
 static int cron_hascore();
 struct bnode *cron_create();
-extern char *ktime_DateOf();
 
 #define	SDTIME		60	/* time in seconds given to a process to evaporate */
 
--- ./src/bozo/fsbnodeops.c.~1~	2003-07-15 19:14:43.000000000 -0400
+++ ./src/bozo/fsbnodeops.c	2003-11-20 13:14:44.000000000 -0500
@@ -45,7 +45,6 @@
 static int fs_procexit(), fs_getstring(), fs_getparm(), fs_restartp();
 static int fs_hascore();
 struct bnode *fs_create();
-struct bnode *fsmr_create();
 
 static SetNeedsClock();
 static NudgeProcs();
--- ./src/bucoord/bc_status.c.~1~	2003-07-15 19:14:46.000000000 -0400
+++ ./src/bucoord/bc_status.c	2003-11-19 22:11:14.000000000 -0500
@@ -147,8 +153,6 @@
     PROCESS dispatchPid;
 
     afs_int32 code = 0;
-    extern struct bc_config *bc_globalConfig;
-    extern struct rx_connection *bc_GetConn();
 
     lastTaskCode = 0;
 
--- ./src/bucoord/bc_status.c.~1~	2003-07-15 19:14:46.000000000 -0400
+++ ./src/bucoord/bc_status.c	2003-11-19 22:11:14.000000000 -0500
@@ -429,7 +433,6 @@
 {
     statusP ptr;
     afs_int32 done = 0, rcode, t;
-    extern statusP findStatus();
 
     t = (TASK_DONE | ABORT_DONE | TASK_ERROR);
     while (!done) {
--- ./src/bucoord/commands.c.~1~	2003-07-15 19:14:47.000000000 -0400
+++ ./src/bucoord/commands.c	2003-11-20 14:34:18.000000000 -0500
@@ -45,7 +45,6 @@
 
 
 extern struct bc_config *bc_globalConfig;
-extern char *ktime_GetDateUsage();
 extern struct bc_dumpSchedule *bc_FindDumpSchedule();
 extern struct bc_volumeSet *bc_FindVolumeSet(struct bc_config *cfg,
 					     char *name);
--- ./src/bucoord/commands.c.~1~	2003-07-15 19:14:47.000000000 -0400
+++ ./src/bucoord/commands.c	2003-11-20 14:34:18.000000000 -0500
@@ -53,12 +52,7 @@
 extern struct ubik_client *cstruct;
 extern int bc_Dumper();		/* function to do dumps */
 extern int bc_Restorer();	/* function to do restores */
-extern void bc_HandleMisc();
-extern afs_int32 ScanDumpHdr();
-extern afs_int32 ScanTapeVolume();
 extern char *whoami;
-extern int VL_ListEntry();
-extern int VL_ListAttributesN2();
 extern struct ktc_token ttoken;
 extern char *tailCompPtr();
 extern statusP createStatusNode();
--- ./src/bucoord/dsvs.c.~1~	2003-07-15 19:14:47.000000000 -0400
+++ ./src/bucoord/dsvs.c	2003-11-20 13:38:58.000000000 -0500
@@ -38,11 +38,6 @@
 #include <afs/bubasics.h>
 #include "bc.h"
 
-extern struct bc_config *bc_globalConfig;
-extern FILE *bc_open();
-extern void bc_HandleMisc();
-extern char *whoami;
-
 static char db_dsvs = 0;	/*Assume debugging output turned off */
 static char mn[] = "dsvs";	/*Module name */
 
--- ./src/bucoord/dump.c.~1~	2003-07-15 19:14:47.000000000 -0400
+++ ./src/bucoord/dump.c	2003-11-20 13:39:03.000000000 -0500
@@ -43,7 +43,6 @@
 
 struct bc_dumpTask bc_dumpTasks[BC_MAXSIMDUMPS];
 
-extern struct bc_config *bc_globalConfig;
 extern char *bc_CopyString();
 extern void bc_HandleMisc();
 extern char *whoami;
--- ./src/bucoord/main.c.~1~	2003-07-15 19:14:47.000000000 -0400
+++ ./src/bucoord/main.c	2003-11-20 15:04:18.000000000 -0500
@@ -51,7 +51,6 @@
 int localauth, interact;
 char tcell[64];
 
-extern int BC_ExecuteRequest();
 extern int bc_AddDumpCmd();
 extern int bc_AddHostCmd();
 extern int bc_AddVolEntryCmd();
--- ./src/bucoord/main.c.~1~	2003-07-15 19:14:47.000000000 -0400
+++ ./src/bucoord/main.c	2003-11-20 15:04:18.000000000 -0500
@@ -83,8 +82,6 @@
 extern int bc_restoreDbCmd();
 extern int bc_saveDbCmd();
 
-extern PrintError();
-
 /*
  * Global configuration information for the Backup Coordinator.
  */
--- ./src/bucoord/restore.c.~1~	2003-07-15 19:14:47.000000000 -0400
+++ ./src/bucoord/restore.c	2003-11-20 13:02:50.000000000 -0500
@@ -38,12 +38,8 @@
 #include <afs/vlserver.h>
 #include "error_macros.h"
 
-
-extern struct bc_config *bc_globalConfig;
 extern struct bc_dumpTask bc_dumpTasks[BC_MAXSIMDUMPS];
-extern void bc_HandleMisc();
 extern char *whoami;
-extern struct rx_connection *bc_GetConn();
 
 #define	BC_MAXLEVELS	    20
 #define	MAXTAPESATONCE	    10
--- ./src/bucoord/volstub.c.~1~	2003-07-15 19:14:47.000000000 -0400
+++ ./src/bucoord/volstub.c	2003-11-20 14:33:48.000000000 -0500
@@ -29,7 +29,6 @@
 #include "bc.h"
 #include <afs/volint.h>
 
-extern int VL_GetEntryByID();
 extern char *whoami;
 
 /* ********************************************************************* */
--- ./src/budb/procs.c.~1~	2003-07-15 19:14:48.000000000 -0400
+++ ./src/budb/procs.c	2003-11-20 14:51:07.000000000 -0500
@@ -65,8 +65,6 @@
 
 extern struct ubik_dbase *BU_dbase;
 extern struct afsconf_dir *BU_conf;	/* for getting cell info */
-extern afs_int32 myHost;
-extern struct memoryDB db;	/* incore copies of db structures */
 
 afs_int32 AddVolume(), AddVolumes(), CreateDump(), DoDeleteDump(),
 DoDeleteTape(), ListDumps();
--- ./src/budb/server.c.~1~	2003-07-15 19:14:48.000000000 -0400
+++ ./src/budb/server.c	2003-11-20 14:31:17.000000000 -0500
@@ -58,10 +58,6 @@
 #include "globals.h"
 #include "afs/audit.h"
 
-
-extern afs_int32 ubik_lastYesTime;
-extern afs_int32 ubik_nBuffers;
-
 struct ubik_dbase *BU_dbase;
 struct afsconf_dir *BU_conf;	/* for getting cell info */
 
--- ./src/butc/dbentries.c.~1~	2003-07-15 19:14:48.000000000 -0400
+++ ./src/butc/dbentries.c	2003-11-20 13:12:32.000000000 -0500
@@ -40,7 +40,6 @@
 
 #include "error_macros.h"
 
-extern struct ubik_client *cstruct;
 dlqlinkT savedEntries;
 dlqlinkT entries_to_flush;
 
--- ./src/butc/lwps.c.~1~	2003-08-08 16:01:25.000000000 -0400
+++ ./src/butc/lwps.c	2003-11-20 13:13:18.000000000 -0500
@@ -40,7 +40,6 @@
 #include "butc_xbsa.h"
 
 /* GLOBAL CONFIGURATION PARAMETERS */
-extern int dump_namecheck;
 extern int queryoperator;
 extern int tapemounted;
 extern char *opencallout;
--- ./src/butc/recoverDb.c.~1~	2003-07-15 19:14:49.000000000 -0400
+++ ./src/butc/recoverDb.c	2003-11-20 13:13:36.000000000 -0500
@@ -38,7 +38,6 @@
 /* GLOBAL CONFIGURATION PARAMETERS */
 extern int autoQuery;
 extern int queryoperator;
-extern int isafile;
 
 /* Handle for the information read from all the tapes of a dump */
 afs_int32 tapepos;		/* when read a label, remember its position */
--- ./src/butc/tcprocs.c.~1~	2003-07-15 19:14:49.000000000 -0400
+++ ./src/butc/tcprocs.c	2003-11-20 13:12:37.000000000 -0500
@@ -41,24 +41,10 @@
 #include <afs/tcdata.h>
 #include "error_macros.h"
 #include "butc_xbsa.h"
-extern afs_int32 xbsaType;
 
 callPermitted(call)
      struct rx_call *call;
 {
-    afs_int32 code;
-
-    struct rx_connection *tconn;
-    rxkad_level level;
-    Date expiration;
-    char name[MAXKTCNAMELEN];
-    char inst[MAXKTCNAMELEN];
-    char celn[MAXKTCREALMLEN];
-    afs_int32 kvno;
-
-    char *cell;
-    afs_int32 flag;
-
     /* before this code can be used, the rx connection, on the bucoord side, must */
     /* be changed so that it will set up for token passing instead of using  a    */
     /* simple rx connection that, below, returns a value of 0 from rx_SecurityClassOf */
--- ./src/des/new_rnd_key.c.~1~	2003-07-15 19:15:00.000000000 -0400
+++ ./src/des/new_rnd_key.c	2003-11-18 12:30:33.000000000 -0500
@@ -76,7 +76,6 @@
 des_random_key(des_cblock key)
 {
     LOCK_INIT if (!is_inited) {
-	void des_init_random_number_generator();
 	des_init_random_number_generator(key);
     }
     UNLOCK_INIT
--- ./src/dir/salvage.c.~1~	2003-07-15 19:15:02.000000000 -0400
+++ ./src/dir/salvage.c	2003-11-21 12:48:47.000000000 -0500
@@ -38,10 +38,7 @@
 
 #define MAXENAME 256
 
-struct DirEntry *GetBlob();
-struct PageHeader *DRead();
 extern afs_int32 DErrno;
-int NameBlobs(), Lookup(), Create(), MakeDir();
 
 /* figure out how many pages in use in a directory, given ptr to its (locked) header */
 static
--- ./src/kauth/admin_tools.c.~1~	2003-07-15 19:15:16.000000000 -0400
+++ ./src/kauth/admin_tools.c	2003-11-20 14:30:18.000000000 -0500
@@ -44,11 +44,8 @@
 #include "kautils.h"
 #include "kaport.h"
 
-
 #define CMD_PARSER_AMBIG_FIX 1	/* allow ambiguous aliases */
 
-extern char *ktime_GetDateUsage();
-
 #define	KA_SIXHOURS	(6*3600)
 
 static struct ubik_client *conn;
--- ./src/kauth/kadatabase.c.~1~	2003-07-15 19:15:16.000000000 -0400
+++ ./src/kauth/kadatabase.c	2003-11-20 14:30:06.000000000 -0500
@@ -35,9 +35,7 @@
 #include "kautils.h"
 #include "kaserver.h"
 
-extern struct kaheader cheader;
 extern Date cheaderReadTime;	/* time cheader last read in */
-extern struct ubik_dbase *KA_dbase;
 
 #define set_header_word(tt,field,value) kawrite ((tt), ((char *)&(cheader.field) - (char *)&cheader), ((cheader.field = (value)), (char *)&(cheader.field)), sizeof(afs_int32))
 
--- ./src/kauth/kaserver.c.~1~	2003-07-15 19:15:16.000000000 -0400
+++ ./src/kauth/kaserver.c	2003-11-20 14:30:00.000000000 -0500
@@ -61,8 +61,6 @@
 
 struct afsconf_dir *KA_conf;	/* for getting cell info */
 
-extern afs_int32 ubik_lastYesTime;
-extern afs_int32 ubik_nBuffers;
 int MinHours = 0;
 int npwSums = KA_NPWSUMS;	/* needs to be variable sometime */
 
--- ./src/kauth/kpasswd.c.~1~	2003-07-15 19:15:16.000000000 -0400
+++ ./src/kauth/kpasswd.c	2003-11-20 13:09:51.000000000 -0500
@@ -83,7 +83,7 @@
 
 static int zero_argc;
 static char **zero_argv;
-extern int init_child(), pasword_bad(), give_to_child(), terminate_child();
+extern int init_child(), give_to_child(), terminate_child();
 
 #ifdef AFS_NT40_ENV
 struct passwd {
--- ./src/kauth/krb_udp.c.~1~	2003-07-15 19:15:17.000000000 -0400
+++ ./src/kauth/krb_udp.c	2003-11-20 14:30:11.000000000 -0500
@@ -84,7 +84,6 @@
     char data[MAX_PKT_LEN];
 };
 
-extern struct kadstats dynamic_statistics;
 extern char *lastOperation;
 extern char lrealm[];
 
--- ./src/libadmin/bos/afs_bosAdmin.c.~1~	2003-07-15 19:15:24.000000000 -0400
+++ ./src/libadmin/bos/afs_bosAdmin.c	2003-11-20 14:39:27.000000000 -0500
@@ -41,48 +41,6 @@
 #endif
 #endif
 
-
-
-/*
- * Prototypes for functions that don't exist in any header files
- */
-
-extern int BOZO_AddCellHost();
-extern int BOZO_AddKey();
-extern int BOZO_AddSUser();
-extern int BOZO_CreateBnode();
-extern int BOZO_DeleteBnode();
-extern int BOZO_DeleteCellHost();
-extern int BOZO_DeleteKey();
-extern int BOZO_DeleteSUser();
-extern int BOZO_EnumerateInstance();
-extern int BOZO_Exec();
-extern int BOZO_GetCellHost();
-extern int BOZO_GetCellName();
-extern int BOZO_GetDates();
-extern int BOZO_GetInstanceInfo();
-extern int BOZO_GetInstanceParm();
-extern int BOZO_GetInstanceParm();
-extern int BOZO_GetRestartTime();
-extern int BOZO_GetStatus();
-extern int BOZO_ListSUsers();
-extern int BOZO_ListKeys();
-extern int BOZO_Prune();
-extern int BOZO_ReBozo();
-extern int BOZO_Restart();
-extern int BOZO_RestartAll();
-extern int BOZO_SetCellName();
-extern int BOZO_SetNoAuthFlag();
-extern int BOZO_SetRestartTime();
-extern int BOZO_SetStatus(struct rx_connection *, char *, afs_int32);
-extern int BOZO_SetTStatus(struct rx_connection *, char *, afs_int32);
-extern int BOZO_ShutdownAll();
-extern int BOZO_StartupAll();
-extern int BOZO_UnInstall();
-extern int BOZO_WaitAll();
-extern int StartBOZO_GetLog();
-extern int StartBOZO_Install();
-
 typedef struct bos_server {
     int begin_magic;
     int is_valid;
--- ./src/libadmin/kas/afs_kasAdmin.c.~1~	2003-07-15 19:15:29.000000000 -0400
+++ ./src/libadmin/kas/afs_kasAdmin.c	2003-11-20 13:19:02.000000000 -0500
@@ -36,7 +36,6 @@
 #undef ENCRYPT
 
 extern int ubik_Call();
-extern int ubik_Call_New();
 extern int ubik_CallIter();
 
 typedef struct {
--- ./src/libadmin/pts/afs_ptsAdmin.c.~1~	2003-07-15 19:15:31.000000000 -0400
+++ ./src/libadmin/pts/afs_ptsAdmin.c	2003-11-20 14:38:40.000000000 -0500
@@ -32,27 +32,6 @@
 #include <afs/ptserver.h>
 
 /*
- * The list of external functions that aren't prototyped anywhere
- */
-
-extern int PR_NameToID();
-extern int PR_AddToGroup();
-extern int PR_ChangeEntry();
-extern int PR_RemoveFromGroup();
-extern int PR_INewEntry();
-extern int PR_NewEntry();
-extern int PR_Delete();
-extern int PR_IDToName();
-extern int PR_ListEntry();
-extern int PR_SetMax();
-extern int PR_ListElements();
-extern int PR_SetFieldsEntry();
-extern int PR_IsAMemberOf();
-extern int PR_ListMax();
-extern int PR_ListOwned();
-extern int PR_ListEntries();
-
-/*
  * IsValidCellHandle - validate the cell handle for making pts
  * requests.
  *
--- ./src/libadmin/test/client.c.~1~	2003-08-08 17:54:41.000000000 -0400
+++ ./src/libadmin/test/client.c	2003-11-20 14:39:43.000000000 -0500
@@ -38,17 +38,6 @@
 #include <pthread.h>
 #endif
 
-extern int RXSTATS_RetrieveProcessRPCStats();
-extern int RXSTATS_RetrievePeerRPCStats();
-extern int RXSTATS_QueryProcessRPCStats();
-extern int RXSTATS_QueryPeerRPCStats();
-extern int RXSTATS_EnableProcessRPCStats();
-extern int RXSTATS_EnablePeerRPCStats();
-extern int RXSTATS_DisableProcessRPCStats();
-extern int RXSTATS_DisablePeerRPCStats();
-extern int RXSTATS_ClearProcessRPCStats();
-extern int RXSTATS_ClearPeerRPCStats();
-
 /*
  * This structure stores the client and server function lists.
  * This is kept separate from the actual interface definitions
--- ./src/libadmin/vos/afs_vosAdmin.c.~1~	2003-07-15 19:15:36.000000000 -0400
+++ ./src/libadmin/vos/afs_vosAdmin.c	2003-11-20 14:37:15.000000000 -0500
@@ -46,8 +46,6 @@
 #include "vsprocs.h"
 #include "lockprocs.h"
 
-extern int VL_GetAddrsU();
-
 typedef struct file_server {
     int begin_magic;
     int is_valid;
--- ./src/libadmin/vos/vosutils.c.~1~	2003-07-15 19:15:36.000000000 -0400
+++ ./src/libadmin/vos/vosutils.c	2003-11-20 14:38:07.000000000 -0500
@@ -26,15 +26,6 @@
 #endif
 
 /*
- * Functions that aren't prototyped, but that we use
- */
-
-extern int VL_CreateEntryN(), VL_CreateEntry(), VL_GetEntryByIDN(),
-VL_GetEntryByID(), VL_GetEntryByNameN(), VL_GetEntryByNameO(),
-VL_ReplaceEntryN(), VL_ReplaceEntry(), VL_ListAttributesN(),
-VL_ListAttributes(), VL_GetAddrsU();
-
-/*
  * VLDB entry conversion routines.
  * convert from one type of VLDB record to another.  There are only
  * two types "old" and "new".
--- ./src/lwp/fasttime.c.~1~	2003-08-08 16:21:27.000000000 -0400
+++ ./src/lwp/fasttime.c	2003-11-20 13:09:05.000000000 -0500
@@ -40,7 +40,6 @@
 #endif
 #include <afs/afsutil.h>
 
-extern char *valloc();
 int ft_debug;
 
 #define TRUE	1
--- ./src/ptserver/testpt.c.~1~	2003-07-15 19:16:03.000000000 -0400
+++ ./src/ptserver/testpt.c	2003-11-20 14:29:54.000000000 -0500
@@ -50,9 +50,6 @@
 #include "pterror.h"
 #include <afs/afsutil.h>
 
-extern char *ucstring();
-extern char *lcstring();
-
 static char *whoami = "testpr";
 static struct afsconf_dir *conf;	/* cell info, set by MyBeforeProc */
 static char conf_dir[100];
--- ./src/rx/rxdebug.c.~1~	2003-07-15 19:16:12.000000000 -0400
+++ ./src/rx/rxdebug.c	2003-11-20 14:27:44.000000000 -0500
@@ -53,8 +53,6 @@
 
 #define	TIMEOUT	    20
 
-extern struct hostent *hostutil_GetHostByName();
-
 static short
 PortNumber(aport)
      register char *aport;
--- ./src/rxkad/rxkad_client.c.~1~	2003-07-15 19:16:42.000000000 -0400
+++ ./src/rxkad/rxkad_client.c	2003-11-20 14:28:26.000000000 -0500
@@ -66,8 +66,6 @@
 #include "private_data.h"
 #define XPRT_RXKAD_CLIENT
 
-char *rxi_Alloc();
-
 #ifndef max
 #define	max(a,b)    ((a) < (b)? (b) : (a))
 #endif /* max */
--- ./src/rxkad/rxkad_common.c.~1~	2003-07-15 19:16:42.000000000 -0400
+++ ./src/rxkad/rxkad_common.c	2003-11-20 14:28:41.000000000 -0500
@@ -74,8 +74,6 @@
 #include "private_data.h"
 #define XPRT_RXKAD_COMMON
 
-char *rxi_Alloc();
-
 #ifndef afs_max
 #define	afs_max(a,b)    ((a) < (b)? (b) : (a))
 #endif /* afs_max */
--- ./src/ubik/udebug.c.~1~	2003-07-15 19:17:05.000000000 -0400
+++ ./src/ubik/udebug.c	2003-11-20 14:29:37.000000000 -0500
@@ -45,8 +45,6 @@
 #include "ubik.h"
 #include "ubik_int.h"
 
-extern struct hostent *hostutil_GetHostByName();
-
 static short
 PortNumber(register char *aport)
 {
--- ./src/viced/physio.c.~1~	2003-07-15 19:17:32.000000000 -0400
+++ ./src/viced/physio.c	2003-11-20 14:36:41.000000000 -0500
@@ -51,8 +51,6 @@
 #endif
 #define PAGESIZE 2048
 
-extern int LogLevel;
-
 afs_int32 lpErrno, lpCount;
 
 /* returns 0 on success, errno on failure */
--- ./src/vlserver/vlclient.c.~1~	2003-07-15 19:17:34.000000000 -0400
+++ ./src/vlserver/vlclient.c	2003-11-20 15:26:46.000000000 -0500
@@ -72,7 +72,6 @@
 void fill_entry();
 void fill_update_entry();
 
-extern int VL_GetAddrsU(), VL_RegisterAddrs();
 #define	VL_NUMBER_OPCODESX	34
 static char *opcode_names[VL_NUMBER_OPCODESX] = {
     "CreateEntry",
--- ./src/vlserver/vlclient.c.~1~	2003-07-15 19:17:34.000000000 -0400
+++ ./src/vlserver/vlclient.c	2003-11-20 15:26:46.000000000 -0500
@@ -118,7 +118,6 @@
     char name[64];
 };
 
-extern int VL_UpdateEntryByName();
 #define	NVOLS	1000
 #define	ALLOCNT 50000
 struct Vlent *VLa[NVOLS];
--- ./src/vlserver/vlclient.c.~1~	2003-07-15 19:17:34.000000000 -0400
+++ ./src/vlserver/vlclient.c	2003-11-20 15:26:46.000000000 -0500
@@ -129,7 +128,6 @@
 struct rx_connection *serverconns[MAXSERVERS];
 char confdir[AFSDIR_PATH_MAX];
 char *(args[50]);
-extern struct cmd_syndesc *cmd_CreateSyntax();
 
 struct Vlent *
 GetVolume(vol, entry)
--- ./src/vlserver/vlserver.c.~1~	2003-08-25 14:24:31.000000000 -0400
+++ ./src/vlserver/vlserver.c	2003-11-20 14:30:23.000000000 -0500
@@ -66,9 +66,6 @@
 extern int afsconf_CheckAuth();
 extern int afsconf_ServerAuth();
 
-extern afs_int32 ubik_lastYesTime;
-extern afs_int32 ubik_nBuffers;
-
 static CheckSignal();
 int LogLevel = 0;
 int smallMem = 0;
--- ./src/vlserver/vlutils.c.~1~	2003-07-15 19:17:34.000000000 -0400
+++ ./src/vlserver/vlutils.c	2003-11-20 13:10:02.000000000 -0500
@@ -35,7 +35,6 @@
 
 extern struct vlheader cheader;
 struct vlheader xheader;
-extern struct ubik_dbase *VL_dbase;
 extern afs_uint32 HostAddress[];
 extern int maxnservers;
 struct extentaddr extentaddr;
--- ./src/vol/fssync.c.~1~	2003-07-15 19:17:38.000000000 -0400
+++ ./src/vol/fssync.c	2003-11-20 14:36:59.000000000 -0500
@@ -90,7 +90,6 @@
 #endif
 #define osi_Assert(e) (void)(e)
 
-extern int LogLevel;		/* Vice loglevel */
 int (*V_BreakVolumeCallbacks) ();
 
 #define MAXHANDLERS	4	/* Up to 4 clients; must be at least 2, so that
--- ./src/vol/fssync.c.~1~	2003-07-15 19:17:38.000000000 -0400
+++ ./src/vol/fssync.c	2003-11-20 14:36:59.000000000 -0500
@@ -123,9 +122,7 @@
     char partName[16];		/* partition name, e.g. /vicepa */
 };
 
-
 /* Forward declarations */
-static int getport();
 static void FSYNC_sync();
 static void FSYNC_newconnection();
 static void FSYNC_com();
--- ./src/vol/ihandle.c.~1~	2003-08-08 16:40:45.000000000 -0400
+++ ./src/vol/ihandle.c	2003-11-20 13:10:53.000000000 -0500
@@ -62,8 +62,6 @@
 #endif /* !O_LARGEFILE */
 #endif /* AFS_NT40_ENV */
 
-extern afs_int32 DErrno;
-
 #ifdef AFS_PTHREAD_ENV
 pthread_once_t ih_glock_once = PTHREAD_ONCE_INIT;
 pthread_mutex_t ih_glock_mutex;
--- ./src/vol/ntops.c.~1~	2003-07-15 19:17:39.000000000 -0400
+++ ./src/vol/ntops.c	2003-11-20 14:53:51.000000000 -0500
@@ -1107,7 +1109,6 @@
     int tag, vno;
     FdHandle_t linkHandle;
     int ninodes = 0;
-    static void AddToZLCDeleteList(char dir, char *name);
     static void DeleteZLCFiles(char *path);
 
     s = nt_HandleToVolDir(path, &myIH);
--- ./src/vol/vol-salvage.c.~1~	2003-08-08 16:40:45.000000000 -0400
+++ ./src/vol/vol-salvage.c	2003-11-20 15:33:31.000000000 -0500
@@ -219,7 +219,6 @@
 #ifdef	AFS_OSF_ENV
 extern void *calloc();
 #endif
-extern char *vol_DevName();
 static char *TimeStamp(time_t clock, int precision);
 
 #define ORPH_IGNORE 0
--- ./src/volser/volmain.c.~1~	2003-09-04 11:57:38.000000000 -0400
+++ ./src/volser/volmain.c	2003-11-20 14:33:03.000000000 -0500
@@ -67,9 +67,7 @@
 #define VolserVersion "2.0"
 #define N_SECURITY_OBJECTS 3
 
-extern int (*vol_PollProc) ();
 extern struct volser_trans *TransList();
-extern int IOMGR_Poll();
 char *GlobalNameHack = NULL;
 int hackIsIn = 0;
 afs_int32 GlobalVolCloneId, GlobalVolParentId;
--- ./src/volser/volmain.c.~1~	2003-09-04 11:57:38.000000000 -0400
+++ ./src/volser/volmain.c	2003-11-20 14:33:03.000000000 -0500
@@ -77,10 +75,6 @@
 int VolumeChanged;		/* XXXX */
 static char busyFlags[MAXHELPERS];
 struct volser_trans *QI_GlobalWriteTrans = 0;
-extern int QI_write();
-extern int QI_flush();
-extern int (*VolWriteProc) ();
-extern int (*VolFlushProc) ();
 extern void AFSVolExecuteRequest();
 extern void RXSTATS_ExecuteRequest();
 struct afsconf_dir *tdir;
--- ./src/volser/volprocs.c.~1~	2003-07-15 19:17:48.000000000 -0400
+++ ./src/volser/volprocs.c	2003-11-20 14:33:07.000000000 -0500
@@ -70,7 +70,6 @@
 extern int DoLogging;
 extern struct volser_trans *FindTrans(), *NewTrans(), *TransList();
 extern struct afsconf_dir *tdir;
-extern char *volutil_PartitionName();
 
 extern void LogError(afs_int32 errcode);
 
--- ./src/volser/volprocs.c.~1~	2003-07-15 19:17:48.000000000 -0400
+++ ./src/volser/volprocs.c	2003-11-20 14:33:07.000000000 -0500
@@ -88,10 +87,9 @@
 VolDeleteVolume(), VolClone();
 afs_int32 VolReClone(), VolTransCreate(), VolGetNthVolume(), VolGetFlags(),
 VolForward(), VolDump();
-afs_int32 VolForwardMultiple();
 afs_int32 VolRestore(), VolEndTrans(), VolSetForwarding(), VolGetStatus(),
 VolSetInfo(), VolGetName();
-afs_int32 VolSignalRestore(), VolListPartitions(), VolListOneVolume(),
+afs_int32 VolListPartitions(), VolListOneVolume(),
 VolXListOneVolume(), VolXListVolumes();
 afs_int32 VolListVolumes(), XVolListPartitions(), VolMonitor(),
 VolSetIdsTypes(), VolSetDate(), VolSetFlags();
--- ./src/volser/vos.c.~1~	2003-11-12 15:42:04.000000000 -0500
+++ ./src/volser/vos.c	2003-11-20 14:33:44.000000000 -0500
@@ -76,9 +76,6 @@
     struct tqElem *next;
 };
 
-
-struct hostent *hostutil_GetHostByName(register char *ahost);
-
 #define COMMONPARMS     cmd_Seek(ts, 12);\
 cmd_AddParm(ts, "-cell", CMD_SINGLE, CMD_OPTIONAL, "cell name");\
 cmd_AddParm(ts, "-noauth", CMD_FLAG, CMD_OPTIONAL, "don't authenticate");\
--- ./src/volser/vos.c.~1~	2003-11-12 15:42:04.000000000 -0500
+++ ./src/volser/vos.c	2003-11-20 14:33:44.000000000 -0500
@@ -94,23 +91,6 @@
 afs_int32 tserver;
 extern struct ubik_client *cstruct;
 const char *confdir;
-extern struct rx_connection *UV_Bind();
-extern int UV_SetSecurity();
-extern int UV_SetVolumeInfo();
-extern int vsu_SetCrypt();
-extern VL_SetLock();
-extern VL_ReleaseLock();
-extern VL_DeleteEntry();
-extern VL_ListEntry();
-extern VL_GetAddrs();
-extern VL_GetAddrsU();
-extern VL_ChangeAddr();
-
-extern int vsu_ExtractName();
-extern PrintError();
-extern void EnumerateEntry();
-extern void SubEnumerateEntry();
-
 
 static struct tqHead busyHead, notokHead;
 
--- ./src/volser/vsprocs.c.~1~	2003-07-15 19:17:49.000000000 -0400
+++ ./src/volser/vsprocs.c	2003-11-20 21:55:04.000000000 -0500
@@ -64,17 +64,8 @@
 
 #include <volser_prototypes.h>
 
-afs_int32 VolumeExists(), CheckVldbRWBK(), CheckVldb();
-
 struct ubik_client *cstruct;
 int verbose = 0;
-extern int VL_GetNewVolumeId();
-extern int VL_SetLock();
-extern int VL_ReleaseLock();
-extern int VL_DeleteEntry();
-
-void MapNetworkToHost();
-void MapHostToNetwork();
 
 struct release {
     afs_int32 time;
--- ./src/volser/vsutils.c.~1~	2003-07-15 19:17:49.000000000 -0400
+++ ./src/volser/vsutils.c	2003-11-20 14:32:54.000000000 -0500
@@ -56,11 +56,6 @@
 
 struct ubik_client *cstruct;
 static rxkad_level vsu_rxkad_level = rxkad_clear;
-extern int VL_CreateEntry(), VL_CreateEntryN();
-extern int VL_GetEntryByID(), VL_GetEntryByIDN();
-extern int VL_GetEntryByNameO(), VL_GetEntryByNameN();
-extern int VL_ReplaceEntry(), VL_ReplaceEntryN();
-extern int VL_ListAttributes(), VL_ListAttributesN(), VL_ListAttributesN2();
 
 static void
 ovlentry_to_nvlentry(oentryp, nentryp)
--- ./src/volser/vsutils.c.~1~	2003-07-15 19:17:49.000000000 -0400
+++ ./src/volser/vsutils.c	2003-11-20 14:32:54.000000000 -0500
@@ -298,7 +293,7 @@
 #define GETADDRUCACHESIZE             64
 struct cacheips cacheips[GETADDRUCACHESIZE];
 int cacheip_index = 0;
-extern int VL_GetAddrsU();
+
 VLDB_IsSameAddrs(serv1, serv2, errorp)
      afs_int32 serv1, serv2, *errorp;
 {

--------------000509040104010503090302--