[OpenAFS-devel] [PATCH] flexelint: missing prototypes
Joe Buehler
jbuehler@hekimian.com
Fri, 21 Nov 2003 14:37:29 -0500
This is a multi-part message in MIME format.
--------------050602090804090907090508
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
This patch adds a bunch of missing prototypes. One set is commented
out because it applies to some printf-like functions that are implemented
the way it used to be done before varargs existed, and they need to be
unprototyped or the code will fail to compile.
There are a number of functions in the OpenAFS code that need to be
converted to use varargs...
--
Joe Buehler
--------------050602090804090907090508
Content-Type: text/plain;
name="temp.patch.missing-prototypes"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="temp.patch.missing-prototypes"
--- ./obj/dest/free/include/afs/dir.h.~1~ 2003-07-15 19:15:02.000000000 -0400
+++ ./obj/dest/free/include/afs/dir.h 2003-11-20 11:13:34.000000000 -0500
@@ -98,6 +98,17 @@
extern struct DirEntry *GetBlob(void *dir, afs_int32 blobno);
extern int DirHash(register char *string);
+extern int DStat(int *abuffers, int *acalls, int *aios);
+extern int DInit(int abuffers);
+extern void *DRead(register afs_int32 *fid, register int page);
+extern void DRelease(register struct buffer *bp, int flag);
+extern int DVOffset(register void *ap);
+extern void DZap(register afs_int32 *fid);
+extern int DFlushVolume(register afs_int32 vid);
+extern int DFlushEntry(register afs_int32 *fid);
+extern int DFlush();
+extern void *DNew(register afs_int32 *fid, register int page);
+
#ifdef KERNEL
extern int afs_dir_NameBlobs(char *name);
extern int afs_dir_Create(void *dir, char *entry, void *vfid);
--- ./src/WINNT/afsd/cm_freelance.c.~1~ 2001-11-02 16:00:41.000000000 -0500
+++ ./src/WINNT/afsd/cm_freelance.c 2003-11-19 16:57:42.000000000 -0500
@@ -18,6 +18,8 @@
#include "cm_freelance.h"
#include "stdio.h"
+extern void afsi_log(char *pattern, ...);
+
int cm_noLocalMountPoints;
int cm_fakeDirSize;
int cm_fakeDirCallback=0;
--- ./src/WINNT/afsd/cm_vnodeops.c.~1~ 2001-10-31 22:40:21.000000000 -0500
+++ ./src/WINNT/afsd/cm_vnodeops.c 2003-11-20 13:25:48.000000000 -0500
@@ -28,6 +28,10 @@
#define ROVOL 1
#define BACKVOL 2
+#ifdef DEBUG
+extern void afsi_log(char *pattern, ...);
+#endif
+
unsigned int cm_mountRootGen = 0;
char cm_sysName[100];
--- ./src/WINNT/afsd/smb.h.~1~ 2001-11-21 01:44:28.000000000 -0500
+++ ./src/WINNT/afsd/smb.h 2003-11-19 16:52:05.000000000 -0500
@@ -344,6 +344,10 @@
extern smb_user_t *smb_FindUID(smb_vc_t *vcp, unsigned short uid, int flags);
+extern smb_username_t *smb_FindUserByName(char *usern, char *machine, int flags);
+
+extern smb_user_t *smb_FindUserByNameThisSession(smb_vc_t *vcp, char *usern);
+
extern void smb_ReleaseUID(smb_user_t *uidp);
extern cm_user_t *smb_GetUser(smb_vc_t *vcp, smb_packet_t *inp);
--- ./src/WINNT/afsd/smb.h.~1~ 2001-11-21 01:44:28.000000000 -0500
+++ ./src/WINNT/afsd/smb.h 2003-11-19 16:52:05.000000000 -0500
@@ -423,6 +427,8 @@
extern void smb_FormatResponsePacket(smb_vc_t *vcp, smb_packet_t *inp,
smb_packet_t *op);
+extern char *myCrt_2Dispatch(int i);
+
extern unsigned int smb_Attributes(cm_scache_t *scp);
extern int smb_ChainFID(int fid, smb_packet_t *inp);
--- ./src/bozo/bnode.p.h.~1~ 2003-07-15 19:14:43.000000000 -0400
+++ ./src/bozo/bnode.p.h 2003-11-20 09:51:36.000000000 -0500
@@ -135,3 +135,5 @@
extern int bnode_Init( /* no parms */ );
extern afs_int32 bnode_Create();
extern struct bnode *bnode_FindInstance();
+extern int bnode_WaitStatus(register struct bnode *abnode, int astatus);
+extern int bnode_SetStat(register struct bnode *abnode, register int agoal);
--- ./src/bucoord/bc_status.c.~1~ 2003-07-15 19:14:46.000000000 -0400
+++ ./src/bucoord/bc_status.c 2003-11-19 22:11:14.000000000 -0500
@@ -41,6 +41,10 @@
curPollPtr->flags &= ~(clear); \
unlock_Status();
+extern struct bc_config *bc_globalConfig;
+extern afs_int32 bc_GetConn(struct bc_config *aconfig, afs_int32 aport, struct rx_connection **tconn);
+extern statusP findStatus(afs_uint32 taskId);
+
/* globals for backup coordinator status management */
dlqlinkT statusHead; /* chain of status blocks */
--- ./src/bucoord/vol_sets.c.~1~ 2003-07-15 19:14:47.000000000 -0400
+++ ./src/bucoord/vol_sets.c 2003-11-20 13:39:13.000000000 -0500
@@ -39,8 +39,9 @@
extern struct bc_config *bc_globalConfig;
extern struct udbHandleS udbHandle;
extern char *whoami;
-extern struct bc_volumeSet *bc_FindVolumeSet(struct bc_config *cf,
- char *name);
+extern struct bc_volumeSet *bc_FindVolumeSet(struct bc_config *cf, char *name);
+extern void FreeVolumeSet(struct bc_volumeSet *avset);
+
/* ------------------------------------
* command level routines
--- ./src/budb/database.h.~1~ 2003-07-15 19:14:48.000000000 -0400
+++ ./src/budb/database.h 2003-11-20 08:52:52.000000000 -0500
@@ -314,3 +314,7 @@
struct memoryHashTable *ht_GetType();
extern afs_uint32 ht_HashEntry();
extern dbadr ht_LookupBucket();
+
+extern afs_int32 dbwrite(struct ubik_trans *ut, afs_int32 pos, char *buff, afs_int32 len);
+extern void db_panic(char *reason);
+extern void ht_Reset(struct memoryHashTable *mht);
--- ./src/butc/error_macros.h.~1~ 2000-11-04 05:04:13.000000000 -0500
+++ ./src/butc/error_macros.h 2003-11-20 09:46:16.000000000 -0500
@@ -24,3 +24,19 @@
code = evalue; \
goto abort_exit; \
}
+
+/*need conversion to varargs*//*extern void ELog(afs_int32 task, char *str, char *a, char *b, char *c, char *d, char *e, char *f, char *g, char *h, char *i, char *j);
+extern void ErrorLog(int debug, afs_int32 task, afs_int32 error1, afs_int32 error2, char *str, char *a, char *b, char *c, char *d, char *e, char *f, char *g, char *h, char *i, char *j);
+extern void TLog(afs_int32 task, char *str, char *a, char *b, char *c, char *d, char *e, char *f, char *g, char *h, char *i, char *j);
+extern void TapeLog(int debug, afs_int32 task, afs_int32 error1, afs_int32 error2, char *str, char *a, char *b, char *c, char *d, char *e, char *f, char *g, char *h, char *i, char *j);*/
+
+extern void FreeNode(afs_int32 taskID);
+extern void CreateNode(struct dumpNode **newNode);
+extern void LeaveDeviceQueue(struct deviceSyncNode *devLatch);
+extern void EnterDeviceQueue(struct deviceSyncNode *devLatch);
+extern Date ExpirationDate(afs_int32 dumpid);
+extern void InitNodeList(afs_int32 portOffset);
+
+/* bucoord/status.c */
+extern void clearStatus(afs_uint32 taskId, afs_uint32 flags);
+extern void setStatus(afs_uint32 taskId, afs_uint32 flags);
--- ./src/dir/dir.h.~1~ 2003-07-15 19:15:02.000000000 -0400
+++ ./src/dir/dir.h 2003-11-20 11:13:48.000000000 -0500
@@ -98,6 +98,17 @@
extern struct DirEntry *GetBlob(void *dir, afs_int32 blobno);
extern int DirHash(register char *string);
+extern int DStat(int *abuffers, int *acalls, int *aios);
+extern int DInit(int abuffers);
+extern void *DRead(register afs_int32 *fid, register int page);
+extern void DRelease(register struct buffer *bp, int flag);
+extern int DVOffset(register void *ap);
+extern void DZap(register afs_int32 *fid);
+extern int DFlushVolume(register afs_int32 vid);
+extern int DFlushEntry(register afs_int32 *fid);
+extern int DFlush();
+extern void *DNew(register afs_int32 *fid, register int page);
+
#ifdef KERNEL
extern int afs_dir_NameBlobs(char *name);
extern int afs_dir_Create(void *dir, char *entry, void *vfid);
--- ./src/kauth/kautils.p.h.~1~ 2003-07-15 19:15:16.000000000 -0400
+++ ./src/kauth/kautils.p.h 2003-11-20 08:33:30.000000000 -0500
@@ -151,6 +151,10 @@
extern void ka_timestr(afs_int32 time, char *tstr, afs_int32 tlen);
+extern void ka_debugKeyCache(struct ka_debugInfo *info);
+
+extern void save_principal(char *p, char *n, char *i, char *c);
+
extern afs_int32 ka_GetAFSTicket(char *name, char *instance, char *realm,
Date lifetime, afs_int32 flags);
--- ./src/ubik/ubik.p.h.~1~ 2003-07-15 19:17:05.000000000 -0400
+++ ./src/ubik/ubik.p.h 2003-11-19 21:41:17.000000000 -0500
@@ -329,6 +329,13 @@
extern int DISK_WriteV();
extern int DISK_Truncate();
extern int DISK_SetVersion();
+
+/* disk.c */
+extern int udisk_abort(struct ubik_trans *atrans);
+
+/* lock.c */
+extern void ulock_relLock(struct ubik_trans *atrans);
+
#endif /* UBIK_INTERNALS */
extern afs_int32 ubik_nBuffers;
--- ./src/ubik/ubik.p.h.~1~ 2003-07-15 19:17:05.000000000 -0400
+++ ./src/ubik/ubik.p.h 2003-11-19 21:41:17.000000000 -0500
@@ -347,5 +354,8 @@
extern afs_int32 ubik_ClientDestroy(struct ubik_client *aclient);
+/* ubik.c */
+extern int ubik_BeginTrans(register struct ubik_dbase *dbase, afs_int32 transMode, struct ubik_trans **transPtr);
+extern int ubik_EndTrans(register struct ubik_trans *transPtr);
#endif /* UBIK_H */
--- ./src/update/server.c.~1~ 2003-07-15 19:17:07.000000000 -0400
+++ ./src/update/server.c 2003-11-20 15:02:31.000000000 -0500
@@ -54,6 +54,8 @@
#include "global.h"
extern int UPDATE_ExecuteRequest();
+extern rxkad_level StringToLevel(char *name);
+
static int AddObject(char **expPath, char *dir);
static int PathInDirectory(char *dir, char *path);
--- ./src/vlserver/vlserver.p.h.~1~ 2003-07-15 19:17:34.000000000 -0400
+++ ./src/vlserver/vlserver.p.h 2003-11-20 08:43:23.000000000 -0500
@@ -128,4 +128,6 @@
#define VLog(level, str) ViceLog(5, str)
+extern int FreeBlock(struct ubik_trans *trans, afs_int32 blockindex);
+
#endif /* _VLSERVER_ */
--- ./src/volser/volser.p.h.~1~ 2003-07-15 19:17:48.000000000 -0400
+++ ./src/volser/volser.p.h 2003-11-20 09:09:27.000000000 -0500
@@ -154,4 +154,9 @@
#define RV_OFFLINE 0x2
#define RV_RDONLY 0x10000
+extern afs_uint32 vsu_GetVolumeID(char *astring, struct ubik_client *acstruct, afs_int32 *errp);
+extern int vsu_ExtractName(char rname[], char name[]);
+extern afs_int32 vsu_ClientInit(int noAuthFlag, char *confDir, char *cellName, afs_int32 sauth, struct ubik_client **uclientp, int (*secproc)());
+extern void vsu_SetCrypt(int cryptflag);
+
#endif /* _VOLSER_ */
--------------050602090804090907090508--