[OpenAFS-devel] Refactoring the Solaris libafs code base

[Russ Allbery]

Jeffrey Altman <jaltman@secure-endpoints.com> writes:

> The Microsoft compilers have included fcntl.h going back at least a
> decade.  HAVE_FCNTL_H is defined in the windows config.h file.  So if
> you are asking if #ifdef HAVE_FCNTL_H can be removed, the answer from
> the perspective of Windows is 'yes' but I really must ask "why bother?"
> If the code compiles cleanly now, why remove the #ifdef?

The #ifdef maze is ugly and can be fragile if one wants to redo how
configure works.  It's not a big deal (about at the same level as removing
unused variables), but it's a cleanup that I like, particularly since with
some of the source in the tree the #ifdef maze is complex enough that I'm
pretty sure there are bugs in unusual cases.

I suppose that means I should take on reviewing and applying the patch.

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>