[OpenAFS-devel] Refactoring the Solaris libafs code base

Sean O'Malley omalleys@msu.edu
Thu, 28 Dec 2006 12:48:44 -0500 (EST)


On Thu, 28 Dec 2006, Jeffrey Altman wrote:

> I've re-read the above sentences several times now.  I'm not sure I
> understand which inclusions of fcntl.h you are referring to.  Do you
> build the Windows tree?   If not, I would leave it alone.
>
> The Microsoft compilers have included fcntl.h going back at least a
> decade.  HAVE_FCNTL_H is defined in the windows config.h file.  So if
> you are asking if   #ifdef HAVE_FCNTL_H  can be removed, the answer
> from the perspective of Windows is 'yes' but I really must ask "why
> bother?"  If the code compiles cleanly now, why remove the #ifdef?

It is actually:
#ifdef AFS_NT40_ENV
#include <fcntl.h>
#else

--------------------------------------
  Sean O'Malley, Information Technologist
  Michigan State University
-------------------------------------