[OpenAFS-devel] ENABLE_BUGFIX_1165

[Jeffrey Hutzelman]

On Monday, February 20, 2006 10:23:39 AM +0100 Harald Barth 
<haba@pdc.kth.se> wrote:

>
> habarber:openafs-1.4.1-rc8$ find . -type f | xargs grep 'BUGFIX_1165'
> ./src/libadmin/vos/vsprocs.c:#ifdef     ENABLE_BUGFIX_1165
> ./src/libadmin/vos/vsprocs.c:#ifdef     ENABLE_BUGFIX_1165
> ./src/libadmin/vos/vsprocs.c:#ifdef     ENABLE_BUGFIX_1165
> ./src/libadmin/vos/vsprocs.c:#ifdef     ENABLE_BUGFIX_1165
> ./src/libadmin/vos/vsprocs.c:#ifdef     ENABLE_BUGFIX_1165
> ./src/volser/vsprocs.c:#ifdef   ENABLE_BUGFIX_1165
> ./src/volser/vsprocs.c:#ifdef   ENABLE_BUGFIX_1165
> ./src/volser/vsprocs.c:#ifdef   ENABLE_BUGFIX_1165
> ./src/volser/vsprocs.c:#ifdef   ENABLE_BUGFIX_1165
> ./src/volser/vsprocs.c:#ifdef   ENABLE_BUGFIX_1165
>
> This bugfix seems to copy volume meta information over volume moves.
> Is this enabled? Disabled? Not needed? Should it be enabled or
> deleted?

This is to address an issue reported to IBM ages ago.  The effect of this
fix at the time it was introduced was to preserve the dayUse (and only that 
field) across a volume move; today it would also preserve the volume update 
counter.

If this were to be enabled, it should be modified to call init_volintInfo 
to correctly initialize the volintInfo structure it is going to use, then 
explicitly copy the fields it wants to update.

Turning this on would be a behavior change; I assume the reason it never 
got enabled in the default build is because IBM was afraid the behavior 
change would cause problems for someone.

-- Jeff