[OpenAFS-devel] openafs-1.4.1-rc5 & sparc64_linux26

[Russ Allbery]

Jeffrey Hutzelman <jhutz@cmu.edu> writes:

> Your change was, essentially, this:

> -#ifdef AFS_SPARC64_LINUX24_ENV
> -    if (current->thread.flags & SPARC_FLAG_32BIT)
> -#elif defined(AFS_SPARC64_LINUX20_ENV)
> -    if (current->tss.flags & SPARC_FLAG_32BIT)
> +#ifdef AFS_SPARC64_LINUX20_ENV
> +#ifdef AFS_SPARC64_LINUX26_ENV
> +    if (test_thread_flag(TIF_32BIT))
> +#elif defined (AFS_SPARC64_LINUX24_ENV)
> +    if (current->thread.flags & SPARC_FLAG_32BIT)
> +#endif

> I would suggest instead a smaller, simpler change which does not 
> gratuitously break support for another platform:

> -#ifdef AFS_SPARC64_LINUX24_ENV
> +#ifdef AFS_SPARC64_LINUX26_ENV
> +    if (test_thread_flag(TIF_32BIT))
> +#elif defined(AFS_SPARC64_LINUX24_ENV)
>     if (current->thread.flags & SPARC_FLAG_32BIT)
> #elif defined(AFS_SPARC64_LINUX20_ENV)
>     if (current->tss.flags & SPARC_FLAG_32BIT)

There's already a patch for this in trunk that rearranges this code and
simplifies it.  I just need to pull it up.  I'll do that.  Sorry to have
not done that before the last rc and saved some work.  :/

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>