[OpenAFS-devel] [PATCH] crget() memory allocation oddity

Troy Benjegerdes hozer@hozed.org
Mon, 5 Jun 2006 12:11:18 -0500


On Fri, Jun 02, 2006 at 01:17:04PM -0400, Jeffrey Hutzelman wrote:
> 
> 
> On Friday, June 02, 2006 01:05:13 PM -0400 chas williams - CONTRACTOR 
> <chas@cmf.nrl.navy.mil> wrote:
> 
> >i have my doubts though about bothering with a pool of creds on linux.
> >kmalloc on the linux already does a bit of work to keep pools
> >of memory available of various sizes and this is just double work.
> 
> I'm not so sure.  Since the OS doesn't actually have creds like we expect, 
> we have to cons them up for every filesystem operation (that is, every time 
> crget() is called).  That's pretty frequent, and it seems appropriate to 
> avoid the overhead of memory allocation every time.

What exactly do we have in this credential structure that can't be put
into the linux kernel keyring implementation as is? How would the
keyring API need to be changed/extended?