[OpenAFS-devel] [PATCH] fix file locking crash on linux

[Jeffrey Hutzelman]

On Friday, February 09, 2007 12:35:26 PM -0500 Derrick J Brashear 
<shadow@dementia.org> wrote:

> No, the one in the message this message was a followup to. You should go
> read it.

Well, as I already explained to you, it wasn't a followup to anything. 
However, it's now clear to me which crash Chris was trying to fix, and I'm 
still not convinced the proposed change is a good idea; we make a private 
copy specifically to avoid clearing FL_SLEEP in Linux's copy.

What I am convinced of, and I think you have come to this conclusion as 
well, is that fixing the issues with afs_linux_flock() does not belong in 
the critical path of the 1.4.3 release.  So the right answer is to make 
that part of the delta (which was originally submitted as a separate patch) 
go away; you've already said you intend to do that by #ifdef'ing it out for 
now.

That said, of course it doesn't mean we shouldn't keep looking at this and 
either convince ourselves that Chris's patch is correct or else come up 
with something else.

-- Jeff