[OpenAFS-devel] Fwd: [patch review] libafs solaris cleanup

Jim Rees rees@umich.edu
Mon, 12 Feb 2007 12:14:46 -0500


Matt Benjamin wrote:

  Respectfully, I haven't seen this stylistic preference in Unix source 
  code or style guidelines (eg, Rob Pike). 

style(9) calls for using parens.  But most of the existing afs code leaves
out the parens, and I think it's best to be consistent with what we have.

And as Jeffrey notes, it's best not to put in a bunch of style changes in a
patch.