[OpenAFS-devel] Re: unable to push to gerrit (for a different reason now)
Adam Megacz
megacz@hcoop.net
Mon, 13 Jul 2009 20:36:56 -0700
Simon Wilkinson <sxw@inf.ed.ac.uk> writes:
> The committer of the patch doesn't match the email address that gerrit
> knows you as. Either teach git the name that gerrit knows you by (with
> git config user.email), or tell gerrit the email address that git is
> using, by going to http://gerrit.openafs.org/Gerrit#settings,contact
> (after logging in) and clicking 'Register New Email ...'
Hrm, okay, I registered megacz@hcoop.net (which I would like to appear
as the author in my commits), but now the push is complaining about
"invalid committer adam@megacz.com" -- but where is git/gerrit getting
that from? The commits ("git log") clearly show megacz@hcoop.net as
the committer.
I'd rather not register adam@megacz.com with gerrit because I'd prefer
it not to appear in the commits.
Help?
- a
$ git config -l
core.pager=less -FXRS
user.name=Adam Megacz
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
core.ignorecase=true
user.email=megacz@hcoop.net
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
remote.origin.url=git://git.openafs.org/openafs.git
branch.master.remote=origin
branch.master.merge=refs/heads/master
$ git push ssh://gerrit.openafs.org/openafs.git HEAD:refs/changes/58
Counting objects: 17, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 1.74 KiB, done.
Total 11 (delta 9), reused 0 (delta 0)
To ssh://gerrit.openafs.org/openafs.git
! [remote rejected] HEAD -> refs/changes/58 (invalid committer adam@megacz.com)
error: failed to push some refs to 'ssh://gerrit.openafs.org/openafs.git'
$ git log
commit 63bbdd6c66df48a04191f49f1f4b76f6a81bc921
Author: Adam Megacz <megacz@hcoop.net>
Date: Mon Jul 13 20:14:44 2009 -0700
In rxi_SendPacket[List], down hosts if ENETUNREACH or equivalent
This patch causes rxi_SendPacket[List] to "down" a host if
rxi_Sendmsg() returns -ENETUNREACH (or equivalent). Previous behavior
only did this check if defined(KERNEL) becauase non-defined(KERNEL)
implementations did not return meaningful error codes from
rxi_Sendmsg().
Jeff Altman <jaltman@openafs.org> supplied the logic for the
AFS_NT40_ENV case; I was not able to test this (I do not own a
Windows license) and took him on his word.
commit 9b506b711389fdd80ed1a6262df1f3c0b5dc31d6
Author: Adam Megacz <megacz@hcoop.net>
Date: Mon Jul 13 20:11:57 2009 -0700
Use -errno or WSAGetLastError() as return value from rxi_Sendmsg()
This patch causes the pthread and lwp implementations of rxi_Sendmsg()
to use -errno or WSAGetLastError() as the return value if it is
positive. This is required in order to communicate more meaningful
error conditions to rxi_SendPacket[List], which should "down" a host
immediately when it observes ENETUNREACH.
Jeff Altman <jaltman@openafs.org> supplied the logic for the
AFS_NT40_ENV case; I was not able to test this (I do not own a
Windows license) and took him on his word.
commit 243836efbb89a3b863d29ac9b0459411a4b666d5
Author: Simon Wilkinson <sxw@inf.ed.ac.uk>
Date: Tue Jul 14 00:18:25 2009 +0100
...