[OpenAFS-devel] gerrit: "but someone else must approve"

Simon Wilkinson sxw@inf.ed.ac.uk
Mon, 27 Jul 2009 15:03:09 +0100


On 27 Jul 2009, at 02:56, Jeffrey Altman wrote:

> Several people have felt uncomfortable with the language of +1.
> How about just changing it to "Looks good to me".

Okay, so I'm proposing we use the following:

+2: Looks good to me, approved
+1: Looks good to me
0: No score
-1: Please don't merge this in its current form
-2: Do not merge

Thoughts?

S.