[OpenAFS-devel] gerrit: "but someone else must approve"

[Matt W. Benjamin]

+1 Looks good to me

----- "Simon Wilkinson" <sxw@inf.ed.ac.uk> wrote:

> On 27 Jul 2009, at 02:56, Jeffrey Altman wrote:
> 
> > Several people have felt uncomfortable with the language of +1.
> > How about just changing it to "Looks good to me".
> 
> Okay, so I'm proposing we use the following:
> 
> +2: Looks good to me, approved
> +1: Looks good to me
> 0: No score
> -1: Please don't merge this in its current form
> -2: Do not merge
> 
> Thoughts?
> 

-- 

Matt Benjamin

The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel. 734-761-4689
fax. 734-769-8938
cel. 734-216-5309