[OpenAFS] Re: [OpenAFS-devel] exposing RPC code<->name mappings via rxgen extension, a library, and a new utility

[Felix Frank]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--579669762-580698042-1241783630=:15029
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII

On Wed, 6 May 2009, Jeffrey Hutzelman wrote:

> --On Wednesday, May 06, 2009 03:05:39 PM +0200 Felix Frank 
> <Felix.Frank@Desy.de> wrote:
>
>> A proof of concept implementation is already running in DESY's
>> OpenAFS+OSD test cell.
>
> I'm confused.  I thought we were talking about supporting debugging tools 
> like translate_rpc and perhaps rxdebug.  What exactly do you have "running" 
> in your cell?

In RxOsd there are fs threads and fs statistic subcommands that produce 
friendly output detailing currently running RPCs and RPC statistics 
respectively. The effort to merge these advantages into OpenAFS proper was 
what made Steven come forward with this discussion in the first place 
(right?)

The debugging tool was to be more or less of a byproduct (again, did I get 
that right, Steven?)

The fact is that the opcode->name translation used to be hardcoded into fs.
The presented patch eliminates the need to do that. The enhanced fs (and osd)
command used in this cell rely on this patch already.

>>> So the consesus is to
>>> - generate very simple translation functions and
>
> If by "very simple" you mean that id->name translation works exactly like 
> ExecuteRequest, with a combination of switches for sparsely-populated space 
> and dispatch arrays for densly-populated space.  This is very important for 
> time- and space-efficiency, which is why rxgen constructs the ExecuteRequest 
> function the way it does.  Given that we _have_ this code and it is actually 
> _used_ in every service for dispatching RPC's, we know it is right and it 
> should be easily reusable.  That's why I've been suggesting modifying rxgen 
> to emit the new translation function (preferably as part of the libraries it 
> already generates), rather than writing something new from scratch.

I see - I didn't realize what the different ER routine generators were all
about. I've mingled code for generating translational routines into them,
updated patch is attached.
This is quite ugly and obscure, but I'd like to learn if this is in the
right spirit. Any suggestions for better function namings and code structure
are appreciated.

Otherwise (if there are no further fundamental objections) I will clean it
up on my own some time next week.

> And of course, if by "very simple" you also mean that name->id translation 
> does not exist in this form at all, since the only thing I can imagine 
> needing it is a tool like translate_rpc, which will use the tables.

True. This saves us from more trouble.

One question: I'm generating opcodenames<x>[] arrays in parallel to 
StubProcsArray<x>[]. Would it be valid to just use <pkg>_function_names[] 
instead?

Cheers
  - Felix
--579669762-580698042-1241783630=:15029
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=translate_rpc_full.patch
Content-Transfer-Encoding: BASE64
Content-Description: 
Content-Disposition: attachment; filename=translate_rpc_full.patch

SW5kZXg6IHNyYy9yeGdlbi9ycGNfcGFyc2UuYw0KPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQ0KLS0tIHNyYy9yeGdlbi9ycGNfcGFyc2UuYwkocmV2aXNpb24g
NjQ2KQ0KKysrIHNyYy9yeGdlbi9ycGNfcGFyc2UuYwkocmV2aXNpb24gNjUz
KQ0KQEAgLTkyNCw3ICs5MjQsNyBAQA0KIAlpZiAoU2ZsYWcgfHwgY2ZsYWcp
DQogCSAgICBzc19Qcm9jX0NvZGVHZW5lcmF0aW9uKGRlZnApOw0KICAgICB9
DQotICAgIGlmIChTZmxhZykNCisgICAgaWYgKFNmbGFnIHx8IChjZmxhZyAm
JiB4ZmxhZyAmJiAhcHJvY19zcGxpdF9mbGFnKSkNCiAJU1RPUkVWQUwoJnBy
b2NfZGVmaW5lZFtQYWNrYWdlSW5kZXhdLCBkZWZwKTsNCiB9DQogDQpAQCAt
MjAxOSw2ICsyMDE5LDkgQEANCiAgICAgbGlzdCAqbGlzdHA7DQogICAgIGRl
ZmluaXRpb24gKmRlZnA7DQogDQorICAgIGlmICggIVNmbGFnICkNCisJcmV0
dXJuOw0KKw0KICAgICBmX3ByaW50KGZvdXQsICJcbiIpOw0KICAgICBmb3Ig
KGxpc3RwID0gcHJvY19kZWZpbmVkW1BhY2thZ2VJbmRleF07IGxpc3RwICE9
IE5VTEw7DQogCSBsaXN0cCA9IGxpc3RwLT5uZXh0KSB7DQpAQCAtMjAzOCwy
NiArMjA0MSwzNyBAQA0KIA0KICAgICBpZiAoKGxpc3RwID0gcHJvY19kZWZp
bmVkW1BhY2thZ2VJbmRleF0pKSB7DQogCWRlZnAgPSAoZGVmaW5pdGlvbiAq
KSBsaXN0cC0+dmFsOw0KLQlpZiAoZGVmcC0+cGMucHJvY19zZXJ2ZXJzdHVi
KSB7DQotCSAgICBmX3ByaW50KGZvdXQsICJcbnN0YXRpYyBhZnNfaW50MzIg
KCpTdHViUHJvY3NBcnJheSVkW10pKCkgPSB7JXMiLA0KLQkJICAgIFBhY2th
Z2VJbmRleCwgZGVmcC0+cGMucHJvY19zZXJ2ZXJzdHViKTsNCi0JfSBlbHNl
IHsNCi0JICAgIGZfcHJpbnQoZm91dCwNCi0JCSAgICAiXG5zdGF0aWMgYWZz
X2ludDMyICgqU3R1YlByb2NzQXJyYXklZFtdKShzdHJ1Y3QgcnhfY2FsbCAq
el9jYWxsLCBYRFIgKnpfeGRycykgPSB7XyVzJXMlcyIsDQotCQkgICAgUGFj
a2FnZUluZGV4LCBwcmVmaXgsIGRlZnAtPnBjLnByb2NfcHJlZml4LA0KLQkJ
ICAgICgoZGVmaW5pdGlvbiAqKSBsaXN0cC0+dmFsKS0+cGMucHJvY19uYW1l
KTsNCi0JICAgIGRlZnAgPSAoZGVmaW5pdGlvbiAqKSBsaXN0cC0+dmFsOw0K
KwlpZiAoIGNmbGFnICkgIHsNCisJICAgIGZfcHJpbnQoZm91dCwgIlxuc3Rh
dGljIGNoYXIgKm9wbmFtZXMlZFtdID0ge1wiJXMlc1wiIiwgDQorCQkJUGFj
a2FnZUluZGV4LCBkZWZwLT5wYy5wcm9jX3ByZWZpeCwgZGVmcC0+cGMucHJv
Y19uYW1lKTsNCiAJfQ0KKwllbHNlIHsNCisJICAgIGlmIChkZWZwLT5wYy5w
cm9jX3NlcnZlcnN0dWIpIHsNCisJCWZfcHJpbnQoZm91dCwgIlxuc3RhdGlj
IGFmc19pbnQzMiAoKlN0dWJQcm9jc0FycmF5JWRbXSkoKSA9IHslcyIsDQor
CQkJUGFja2FnZUluZGV4LCBkZWZwLT5wYy5wcm9jX3NlcnZlcnN0dWIpOw0K
KwkgICAgfSBlbHNlIHsNCisJCWZfcHJpbnQoZm91dCwNCisJCQkiXG5zdGF0
aWMgYWZzX2ludDMyICgqU3R1YlByb2NzQXJyYXklZFtdKShzdHJ1Y3Qgcnhf
Y2FsbCAqel9jYWxsLCBYRFIgKnpfeGRycykgPSB7XyVzJXMlcyIsDQorCQkJ
UGFja2FnZUluZGV4LCBwcmVmaXgsIGRlZnAtPnBjLnByb2NfcHJlZml4LA0K
KwkJCSgoZGVmaW5pdGlvbiAqKSBsaXN0cC0+dmFsKS0+cGMucHJvY19uYW1l
KTsNCisJCWRlZnAgPSAoZGVmaW5pdGlvbiAqKSBsaXN0cC0+dmFsOw0KKwkg
ICAgfQ0KKwl9DQogCWxpc3RwID0gbGlzdHAtPm5leHQ7DQogICAgIH0NCiAg
ICAgZm9yICg7IGxpc3RwICE9IE5VTEw7IGxpc3RwID0gbGlzdHAtPm5leHQp
IHsNCiAJZGVmcCA9IChkZWZpbml0aW9uICopIGxpc3RwLT52YWw7DQotCWlm
IChkZWZwLT5wYy5wcm9jX3NlcnZlcnN0dWIpIHsNCi0JICAgIGZfcHJpbnQo
Zm91dCwgIiwlcyIsIGRlZnAtPnBjLnByb2Nfc2VydmVyc3R1Yik7DQotCX0g
ZWxzZSB7DQotCSAgICBmX3ByaW50KGZvdXQsICIsIF8lcyVzJXMiLCBwcmVm
aXgsIGRlZnAtPnBjLnByb2NfcHJlZml4LA0KLQkJICAgIGRlZnAtPnBjLnBy
b2NfbmFtZSk7DQorCWlmICggY2ZsYWcgKSB7DQorCSAgICBmX3ByaW50KGZv
dXQsICIsIFwiJXMlc1wiIixkZWZwLT5wYy5wcm9jX3ByZWZpeCxkZWZwLT5w
Yy5wcm9jX25hbWUpOw0KIAl9DQorCWVsc2Ugew0KKwkgICAgaWYgKGRlZnAt
PnBjLnByb2Nfc2VydmVyc3R1Yikgew0KKwkJZl9wcmludChmb3V0LCAiLCVz
IiwgZGVmcC0+cGMucHJvY19zZXJ2ZXJzdHViKTsNCisJICAgIH0gZWxzZSB7
DQorCQlmX3ByaW50KGZvdXQsICIsIF8lcyVzJXMiLCBwcmVmaXgsIGRlZnAt
PnBjLnByb2NfcHJlZml4LA0KKwkJCWRlZnAtPnBjLnByb2NfbmFtZSk7DQor
CSAgICB9DQorCX0NCiAgICAgfQ0KICAgICBmX3ByaW50KGZvdXQsICJ9O1xu
XG4iKTsNCiB9DQpAQCAtMjA2Niw2ICsyMDgwLDE1IEBADQogc3RhdGljIHZv
aWQNCiBlcl9Qcm9jTWFpbkJvZHlfc2V0dXAodm9pZCkNCiB7DQorICAgIGlm
ICggY2ZsYWcgKSB7DQorCWZfcHJpbnQoZm91dCwgImNoYXIgKiVzVHJhbnNs
YXRlT3BDb2RlKGludCBvcClcbntcbiIsDQorCQlQYWNrYWdlUHJlZml4W1Bh
Y2thZ2VJbmRleF0pOw0KKwlmX3ByaW50KGZvdXQsICJcdGlmIChvcCA8ICVz
TE9XRVNUX09QQ09ERSB8fCBvcCA+ICVzSElHSEVTVF9PUENPREUpXG5cdFx0
cmV0dXJuIE5VTEw7XG4iLA0KKwkJUGFja2FnZVByZWZpeFtQYWNrYWdlSW5k
ZXhdLCBQYWNrYWdlUHJlZml4W1BhY2thZ2VJbmRleF0pOw0KKwlmX3ByaW50
KGZvdXQsICJcdHJldHVybiBvcG5hbWVzJWRbb3AgLSAlc0xPV0VTVF9PUENP
REVdO1xufVxuIiwNCisJCVBhY2thZ2VJbmRleCwgUGFja2FnZVByZWZpeFtQ
YWNrYWdlSW5kZXhdKTsNCisJcmV0dXJuOw0KKyAgICB9DQogICAgIGZfcHJp
bnQoZm91dCwgImludCAlcyVzRXhlY3V0ZVJlcXVlc3QocmVnaXN0ZXIgc3Ry
dWN0IHJ4X2NhbGwgKnpfY2FsbClcbiIsDQogCSAgICBwcmVmaXgsIFBhY2th
Z2VQcmVmaXhbUGFja2FnZUluZGV4XSk7DQogICAgIGZfcHJpbnQoZm91dCwg
Intcblx0aW50IG9wO1xuIik7DQpAQCAtMjA4NywxNyArMjExMCwyMyBAQA0K
IHN0YXRpYyB2b2lkDQogZXJfSGVhZG9mT2xkU3R5bGVQcm9jX3NldHVwKHZv
aWQpDQogew0KLSAgICBmX3ByaW50KGZvdXQsDQotCSAgICAiXG5pbnQgJXMl
c0V4ZWN1dGVSZXF1ZXN0IChyZWdpc3RlciBzdHJ1Y3QgcnhfY2FsbCAqel9j
YWxsKVxuIiwNCi0JICAgIHByZWZpeCwNCisgICAgaWYgKCBjZmxhZyApIHsN
CisJZl9wcmludChmb3V0LCAiY2hhciAqJXNUcmFuc2xhdGVPcENvZGUoaW50
IG9wKVxue1xuIiwNCiAJICAgIChjb21iaW5lcGFja2FnZXMgPyBNYXN0ZXJQ
cmVmaXggOiBQYWNrYWdlUHJlZml4W1BhY2thZ2VJbmRleF0pKTsNCi0gICAg
Zl9wcmludChmb3V0LCAie1xuIik7DQotICAgIGZfcHJpbnQoZm91dCwgIlx0
aW50IG9wO1xuIik7DQotICAgIGZfcHJpbnQoZm91dCwgIlx0WERSIHpfeGRy
cztcbiIpOw0KLSAgICBmX3ByaW50KGZvdXQsICJcdCIgImFmc19pbnQzMiB6
X3Jlc3VsdDtcblxuIik7DQotICAgIGZfcHJpbnQoZm91dCwgIlx0eGRycnhf
Y3JlYXRlKCZ6X3hkcnMsIHpfY2FsbCwgWERSX0RFQ09ERSk7XG4iKTsNCi0g
ICAgZl9wcmludChmb3V0LCAiXHR6X3Jlc3VsdCA9IFJYR0VOX0RFQ09ERTtc
biIpOw0KLSAgICBmX3ByaW50KGZvdXQsICJcdGlmICgheGRyX2ludCgmel94
ZHJzLCAmb3ApKSBnb3RvIGZhaWw7XG4iKTsNCisgICAgfQ0KKyAgICBlbHNl
IHsNCisJZl9wcmludChmb3V0LA0KKwkJIlxuaW50ICVzJXNFeGVjdXRlUmVx
dWVzdCAocmVnaXN0ZXIgc3RydWN0IHJ4X2NhbGwgKnpfY2FsbClcbiIsDQor
CQlwcmVmaXgsDQorCQkoY29tYmluZXBhY2thZ2VzID8gTWFzdGVyUHJlZml4
IDogUGFja2FnZVByZWZpeFtQYWNrYWdlSW5kZXhdKSk7DQorCWZfcHJpbnQo
Zm91dCwgIntcbiIpOw0KKwlmX3ByaW50KGZvdXQsICJcdGludCBvcDtcbiIp
Ow0KKwlmX3ByaW50KGZvdXQsICJcdFhEUiB6X3hkcnM7XG4iKTsNCisJZl9w
cmludChmb3V0LCAiXHQiICJhZnNfaW50MzIgel9yZXN1bHQ7XG5cbiIpOw0K
KwlmX3ByaW50KGZvdXQsICJcdHhkcnJ4X2NyZWF0ZSgmel94ZHJzLCB6X2Nh
bGwsIFhEUl9ERUNPREUpO1xuIik7DQorCWZfcHJpbnQoZm91dCwgIlx0el9y
ZXN1bHQgPSBSWEdFTl9ERUNPREU7XG4iKTsNCisJZl9wcmludChmb3V0LCAi
XHRpZiAoIXhkcl9pbnQoJnpfeGRycywgJm9wKSkgZ290byBmYWlsO1xuIik7
DQorICAgIH0NCiAgICAgZl9wcmludChmb3V0LCAiXHRzd2l0Y2ggKG9wKSB7
XG4iKTsNCiB9DQogDQpAQCAtMjEyNSw2ICsyMTU0LDEyIEBADQogc3RhdGlj
IHZvaWQNCiBwcm9jX2VyX2Nhc2UoZGVmaW5pdGlvbiAqIGRlZnApDQogew0K
KyAgICBpZiAoIGNmbGFnICkgew0KKwlmX3ByaW50KGZvdXQsICJcdFx0Y2Fz
ZSAlZDoiLCBkZWZwLT5wYy5wcm9jX29wY29kZW51bSk7DQorCWZfcHJpbnQo
Zm91dCwgIlx0cmV0dXJuIFwiJXMlc1wiO1xuIiwgDQorCQlkZWZwLT5wYy5w
cm9jX3ByZWZpeCwgZGVmcC0+cGMucHJvY19uYW1lKTsNCisJcmV0dXJuOw0K
KyAgICB9DQogICAgIGlmIChvcGNvZGVzbm90YWxsb3dlZFtQYWNrYWdlSW5k
ZXhdKSB7DQogCWZfcHJpbnQoZm91dCwgIlx0XHRjYXNlICVkOlxuIiwgZGVm
cC0+cGMucHJvY19vcGNvZGVudW0pOw0KICAgICB9IGVsc2Ugew0KQEAgLTIx
NDUsMTMgKzIxODAsMTYgQEANCiBlcl9UYWlsb2ZPbGRTdHlsZVByb2Nfc2V0
dXAodm9pZCkNCiB7DQogICAgIGZfcHJpbnQoZm91dCwgIlx0XHRkZWZhdWx0
OlxuIik7DQorICAgIGlmICggY2ZsYWcgKSB7DQorCWZfcHJpbnQoZm91dCwg
Ilx0XHRcdHJldHVybiBOVUxMO1xuXHR9XG59XG4iKTsNCisJcmV0dXJuOw0K
KyAgICB9DQogICAgIGZfcHJpbnQoZm91dCwgIlx0XHRcdHpfcmVzdWx0ID0g
UlhHRU5fT1BDT0RFO1xuIik7DQogICAgIGZfcHJpbnQoZm91dCwgIlx0XHRc
dGJyZWFrO1xuXHR9XG4iKTsNCiAgICAgZl9wcmludChmb3V0LCAiZmFpbDpc
biIpOw0KICAgICBmX3ByaW50KGZvdXQsICJcdHJldHVybiB6X3Jlc3VsdDtc
bn1cbiIpOw0KIH0NCiANCi0NCiB2b2lkDQogaF9vcGNvZGVfc3RhdHModm9p
ZCkNCiB7DQpJbmRleDogc3JjL3J4Z2VuL3JwY19zY2FuLmMNCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0NCi0tLSBzcmMvcnhnZW4vcnBjX3NjYW4uYwkocmV2
aXNpb24gNjQ2KQ0KKysrIHNyYy9yeGdlbi9ycGNfc2Nhbi5jCShyZXZpc2lv
biA2NTMpDQpAQCAtNTcsNiArNTcsNyBAQA0KIGludCBwdXNoZWQgPSAwOwkJ
CS8qIGlzIGEgdG9rZW4gcHVzaGVkICovDQogdG9rZW4gbGFzdHRvazsJCQkv
KiBsYXN0IHRva2VuLCBpZiBwdXNoZWQgKi8NCiBpbnQgc2Nhbl9wcmludCA9
IDE7DQoraW50IHB1dF9kaXJlY3RpdmVzID0gMTsJCS8qIHNldCB0byAwIHRv
IHN1cHByZXNzIHByaW50ZGlyZWN0aXZlKClzICovDQogDQogLyogc3RhdGlj
IHByb3RvdHlwZXMgKi8NCiBzdGF0aWMgdm9pZCBmaW5kc3RyY29uc3QoY2hh
ciAqKnN0ciwgY2hhciAqKnZhbCk7DQpAQCAtNDcwLDYgKzQ3MSw4IEBADQog
dm9pZA0KIHByaW50ZGlyZWN0aXZlKGNoYXIgKmxpbmUpDQogew0KKyAgICBp
ZiAoICFwdXRfZGlyZWN0aXZlcyApDQorCXJldHVybjsNCiAgICAgZl9wcmlu
dChmb3V0LCAiJXMiLCBsaW5lICsgMSk7DQogfQ0KIA0KSW5kZXg6IHNyYy9y
eGdlbi9ycGNfbWFpbi5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g
c3JjL3J4Z2VuL3JwY19tYWluLmMJKHJldmlzaW9uIDY0NikNCisrKyBzcmMv
cnhnZW4vcnBjX21haW4uYwkocmV2aXNpb24gNjUzKQ0KQEAgLTc1LDYgKzc1
LDcgQEANCiAgICAgaW50IHhmbGFnOw0KICAgICBpbnQgeWZsYWc7DQogICAg
IGludCB1ZmxhZzsNCisgICAgaW50IHRmbGFnOw0KICAgICBjaGFyICppbmZp
bGU7DQogICAgIGNoYXIgKm91dGZpbGU7DQogfTsNCkBAIC0xMjMsNiArMTI0
LDggQEANCiB9Ow0KICNlbmRpZg0KIA0KK2V4dGVybiBpbnQgcHV0X2RpcmVj
dGl2ZXM7DQorDQogI2luY2x1ZGUgIkFGU19jb21wb25lbnRfdmVyc2lvbl9u
dW1iZXIuYyINCiANCiAvKiBzdGF0aWMgcHJvdG90eXBlcyAqLw0KQEAgLTE0
Miw2ICsxNDUsNyBAQA0KIAkJICAgICBpbnQgYXBwZW5kKTsNCiBzdGF0aWMg
dm9pZCBTX291dHB1dChjaGFyICppbmZpbGUsIGNoYXIgKmRlZmluZSwgaW50
IGV4dGVuZCwgY2hhciAqb3V0ZmlsZSwNCiAJCSAgICAgaW50IGFwcGVuZCk7
DQorc3RhdGljIHZvaWQgdF9vdXRwdXQoY2hhciAqaW5maWxlLCBpbnQgZXh0
ZW5kLCBjaGFyICpvdXRmaWxlLCBpbnQgYXBwZW5kKTsNCiBzdGF0aWMgY2hh
ciAqdXBwZXJjYXNlKGNoYXIgKnN0cik7DQogDQogaW50DQpAQCAtMTc0LDcg
KzE3OCw3IEBADQogICAgIGlmICghcGFyc2VhcmdzKGFyZ2MsIGFyZ3YsICZj
bWQpKSB7DQogCWZfcHJpbnQoc3RkZXJyLCAidXNhZ2U6ICVzIGluZmlsZVxu
IiwgY21kbmFtZSk7DQogCWZfcHJpbnQoc3RkZXJyLA0KLQkJIiAgICAgICAl
cyBbLWMgfCAtaCB8IC1sIHwgLW0gfCAtQyB8IC1TIHwgLXIgfCAtayB8IC1S
IHwgLXAgfCAtZCB8IC16IHwgLXVdIFstUHByZWZpeF0gWy1JZGlyXSBbLW8g
b3V0ZmlsZV0gW2luZmlsZV1cbiIsDQorCQkiICAgICAgICVzIFstYyB8IC1o
IHwgLWwgfCAtbSB8IC1DIHwgLVMgfCAtciB8IC1rIHwgLVIgfCAtcCB8IC1k
IHwgLXogfCAtdSB8IC10XSBbLVBwcmVmaXhdIFstSWRpcl0gWy1vIG91dGZp
bGVdIFtpbmZpbGVdXG4iLA0KIAkJY21kbmFtZSk7DQogCWZfcHJpbnQoc3Rk
ZXJyLCAiICAgICAgICVzIFstcyB1ZHB8dGNwXSogWy1vIG91dGZpbGVdIFtp
bmZpbGVdXG4iLA0KIAkJY21kbmFtZSk7DQpAQCAtMTk5LDYgKzIwMyw5IEBA
DQogICAgIH0gZWxzZSBpZiAoY21kLlNmbGFnKSB7DQogCU91dEZpbGVGbGFn
ID0gTlVMTDsNCiAJU19vdXRwdXQoY21kLmluZmlsZSwgIi1EUlBDX1NFUlZF
UiIsICFFWFRFTkQsIGNtZC5vdXRmaWxlLCAxKTsNCisgICAgfSBlbHNlIGlm
IChjbWQudGZsYWcpIHsNCisJT3V0RmlsZUZsYWcgPSBOVUxMOw0KKwl0X291
dHB1dChjbWQuaW5maWxlLCAhRVhURU5ELCBjbWQub3V0ZmlsZSwgMSk7DQog
ICAgIH0gZWxzZSB7DQogCWlmIChPdXRGaWxlRmxhZyAmJiAoc3RycmNocihP
dXRGaWxlLCAnLicpID09IE5VTEwpKQ0KIAkgICAgc3RyY2F0KE91dEZpbGUs
ICIuIik7DQpAQCAtNDEzLDkgKzQyMCw5IEBADQogCQkgICAgZl9wcmludChm
b3V0LCAiLFxuXHRcIiVzXCIiLCBmdW5jdGlvbl9saXN0W2pdW2ldKTsNCiAJ
CX0NCiAJICAgIH0NCi0NCiAJICAgIGZfcHJpbnQoZm91dCwgIlxufTtcbiIp
Ow0KIAl9DQorCWVyX1Byb2NfQ29kZUdlbmVyYXRpb24oKTsNCiAgICAgfQ0K
IA0KICAgICBpZiAoZXh0ZW5kICYmIHRlbGwgPT0gZnRlbGwoZm91dCkpIHsN
CkBAIC03NTcsNiArNzY0LDQ3IEBADQogICAgIFNmbGFnID0gMDsNCiB9DQog
DQorLyoNCisgKiBjcmVhdGUgYSBzaW1wbGUgbG9va3VwIHRhYmxlIGZyb20g
aW50ZXJmYWNlIGRlZmluaXRpb24NCisgKi8NCitzdGF0aWMgdm9pZA0KK3Rf
b3V0cHV0KGNoYXIgKmluZmlsZSwgaW50IGV4dGVuZCwgY2hhciAqb3V0Zmls
ZSwgaW50IGFwcGVuZCkNCit7DQorICAgIGNoYXIgKmluY2x1ZGU7DQorICAg
IGNoYXIgKm91dGZpbGVuYW1lOw0KKyAgICBjaGFyIGZ1bGxuYW1lWzEwMjRd
Ow0KKyAgICBkZWZpbml0aW9uICpkZWY7DQorICAgIGxvbmcgdGVsbDsNCisg
ICAgY2hhciAqY3VycmZpbGUgPSAoT3V0RmlsZUZsYWcgPyBPdXRGaWxlIDog
aW5maWxlKTsNCisNCisgICAgcHV0X2RpcmVjdGl2ZXMgPSAwOw0KKw0KKyAg
ICBvcGVuX2lucHV0KGluZmlsZSwgIiIpOw0KKyAgICBtZW1zZXQoZnVsbG5h
bWUsIDAsIHNpemVvZihmdWxsbmFtZSkpOw0KKyAgICBpZiAoYXBwZW5kKSB7
DQorCXN0cmNweShmdWxsbmFtZSwgcHJlZml4KTsNCisJc3RyY2F0KGZ1bGxu
YW1lLCBpbmZpbGUpOw0KKyAgICB9IGVsc2UNCisJc3RyY3B5KGZ1bGxuYW1l
LCBpbmZpbGUpOw0KKyAgICBvdXRmaWxlbmFtZSA9IGV4dGVuZCA/IGV4dGVu
ZGZpbGUoZnVsbG5hbWUsIG91dGZpbGUpIDogb3V0ZmlsZTsNCisgICAgb3Bl
bl9vdXRwdXQoaW5maWxlLCBvdXRmaWxlbmFtZSk7DQorDQorICAgIHRlbGwg
PSBmdGVsbChmb3V0KTsNCisgICAgZmZsdXNoKGZvdXQpOw0KKyAgICB3aGls
ZSAoZGVmID0gZ2V0X2RlZmluaXRpb24oKSkgew0KKwlpZiAoIGRlZi0+ZGVm
X2tpbmQgIT0gREVGX1BST0MgKQ0KKwkgICAgY29udGludWU7DQorCWZmbHVz
aChmb3V0KTsNCisJZnByaW50Zihmb3V0LCAiJWRcdCVzXG4iLCBkZWYtPnBj
LnByb2Nfb3Bjb2RlbnVtLCBkZWYtPnBjLnByb2NfbmFtZSk7DQorICAgIH0N
CisNCisgICAgaWYgKGV4dGVuZCAmJiB0ZWxsID09IGZ0ZWxsKGZvdXQpKSB7
DQorCSh2b2lkKXVubGluayhvdXRmaWxlbmFtZSk7DQorICAgIH0NCisNCisg
ICAgcHV0X2RpcmVjdGl2ZXMgPSAxOw0KK30NCisNCiBzdGF0aWMgY2hhciAq
DQogdXBwZXJjYXNlKGNoYXIgKnN0cikNCiB7DQpAQCAtODEyLDYgKzg2MCw3
IEBADQogCQljYXNlICdrJzoNCiAJCWNhc2UgJ3AnOg0KIAkJY2FzZSAnZCc6
DQorCQljYXNlICd0JzoNCiAJCWNhc2UgJ3UnOg0KIAkJY2FzZSAneCc6DQog
CQljYXNlICd5JzoNCkBAIC04NzMsNiArOTIyLDcgQEANCiAgICAgY21kLT51
ZmxhZyA9IHVmbGFnID0gZmxhZ1sndSddOw0KICAgICBjbWQtPmtmbGFnID0g
a2ZsYWcgPSBmbGFnWydrJ107DQogICAgIGNtZC0+cGZsYWcgPSBmbGFnWydw
J107DQorICAgIGNtZC0+dGZsYWcgPSBmbGFnWyd0J107DQogICAgIGNtZC0+
ZGZsYWcgPSBkZWJ1ZyA9IGZsYWdbJ2QnXTsNCiAgICAgemZsYWcgPSBmbGFn
Wyd6J107DQogICAgIGlmIChjbWQtPnBmbGFnKQ0K

--579669762-580698042-1241783630=:15029--