[OpenAFS-devel] Re: OpenAFS Master Repository branch, master, updated. BP--openafs-stable-1_6_x-32-g2ea508e

[Benjamin Kaduk]

On Wed, 25 Aug 2010, Gerrit Code Review wrote:

> The following commit has been merged in the master branch:
> commit 2ea508ea0f320ca17de6df3526aa7237b998c7be
> Author: Matt Benjamin <matt@linuxbox.com>
> Date:   Wed Aug 25 16:19:18 2010 -0400
>
>    FBSD:  give osi_NetReceive time to shutdown, reprise
>
>    The delay logic needs to follow soshutdown, and precede
>    soclose.  The thread in osi_NetReceive is racing to do
>    another soreceive.  That thread needs to win the race
>    and notice the socket is shut down before rx_socket is
>    torn down.
>
>    Change-Id: Id8424dcfa2498550a190d277017b7ea15fc11023
>    Reviewed-on: http://gerrit.openafs.org/2613
>    Reviewed-by: Derrick Brashear <shadow@dementia.org>
>    Tested-by: Derrick Brashear <shadow@dementia.org>
>
> src/rx/FBSD/rx_knet.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)

Hi Matt,

It looks like I added the soclose call that you remove, here; I'm pretty 
sure that I did so because otherwise I couldn't stop and restart the 
client (i.e. the socket was still open).

Can you unmount /afs (un/reload the kernel module) and remount it after 
this change?

Thanks,

Ben