[OpenAFS-devel] Re: osi_Panic on AIX and IRIX

[Simon Wilkinson]

On 9 Feb 2010, at 23:13, Chaz Chandler wrote:
>>> Has anyone tested AIX recently?
>>=20
>> On 1.5? Probably not, for some value of 'recently'.
>>=20
>=20
> Ahah, this might explain a few things.  We might want to reconsider =
the
> redefinition of osi_Panic in rx_prototypes.h.

1.5 has been built on AIX since that change went in. In fact, commit =
e87be8c5794ccd6eecd3b420dc12085a3608fadb was made as a result of testing =
on AIX6.1 - it removes the prototype so that there's no checking =
performed. The complete change is:

diff --git a/src/rx/rx_prototypes.h b/src/rx/rx_prototypes.h
index 9b114fe..307e75d 100644
--- a/src/rx/rx_prototypes.h
+++ b/src/rx/rx_prototypes.h
@@ -366,9 +366,13 @@ extern osi_socket rxi_GetHostUDPSocket(u_int host, =
u_short por
 #if defined(KERNEL) && (defined(AFS_AIX_ENV) && =
!defined(AFS_AIX61_ENV))
 extern void osi_Panic(char *fmt, void *a1, void *a2, void *a3);
 #else
+#ifdef AFS_AIX61_ENV
+/* No prototype. Deliberate, since there's no vprintf et al */
+#else
 extern void osi_Panic(char *fmt, ...);
 #endif
 #endif
+#endif
 extern int osi_utoa(char *buf, size_t len, unsigned long val);
 extern void rxi_InitPeerParams(struct rx_peer *pp);
 extern void shutdown_rxkernel(void);

S.