[OpenAFS-devel] Linux atime nits

Marc Aurele La France tsi@ualberta.ca
Wed, 6 Jan 2010 07:06:15 -0700 (Mountain Standard Time)


Hi.

src/afs/LINUX*/osi_file.c (all versions) should set the inode's S_NOATIME, 
instead of MS_NOATIME, as the latter is a super block flag, which in recent 
kernels collides with another inode flag.  This means preventing atime 
updates for cache files isn't currently effective.

Also, given AFS itself doesn't appear to track access times, shouldn't 
src/afs/LINUX*/osi_vfsops.c (again, all versions) set MS_NOATIME in its super 
block?

Thanks.

Marc.

+----------------------------------+----------------------------------+
|  Marc Aurele La France           |  work:   1-780-492-9310          |
|  Academic Information and        |  fax:    1-780-492-1729          |
|    Communications Technologies   |  email:  tsi@ualberta.ca         |
|  352 General Services Building   +----------------------------------+
|  University of Alberta           |                                  |
|  Edmonton, Alberta               |    Standard disclaimers apply    |
|  T6G 2H1                         |                                  |
|  CANADA                          |                                  |
+----------------------------------+----------------------------------+