[OpenAFS-devel] Preferred method for flagging patches as "safe to build"

[Jeffrey Hutzelman]

--On Tuesday, July 27, 2010 04:13:35 PM -0400 Jeffrey Altman 
<jaltman@secure-endpoints.com> wrote:

>
> On 7/26/2010 12:39 PM, Jason Edgecombe wrote:
>> Hi everyone,
>>
>> I want some input on how to approve patches for building with buildbot.
>> I see the following options:
>>
>> 1. Make a category in Gerrit and give certain people the ability to set
>> this category.
>
> Too much manual effort.
>
>> 2. Automatically build patches sent from an approved list of people and
>> additionally build anything with a +1 from that same list.
>
> This is desirable.  The goal is to reduce the manual effort required by
> those with bits.  By having the majority of submissions (those from
> trusted submitters) be automatically built, we can avoid reviewing
> patches that fail.

Automatically building patches from trusted submitters is desirable.
Overloading +1 code review to mean "safe to build" is not desirable, 
because it means anyone on the trusted list has to be careful not to 
approve code changes if they haven't carefully reviewed any build system 
changes.

-- Jeff