[OpenAFS-devel] Issues with my precache patch (was: Documentation for fs precache)

[Jeffrey Altman]

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig2B823621B999F3225145D219
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 10/19/2010 2:02 PM, Phillip Moore wrote:
>=20
> That means I will need a new kernel module installed in order to test
> this, doesn't it?
>=20
> Is there anything I need to worry about if I change
>  DECL_PIOCTL(PPrecache) to behave more
> like DECL_PIOCTL(PSetCachingThreshold)?
>=20
> The change seems pretty obvious, but this is the first time (OK, in
> about 13 years) that I've touched any of the code in the kernel module.=
 =20

Be very careful about modifying pioctls.  They are effectively RPCs and
you can't be sure that the clients (userland fs) and servers (kernel
modules) will be updates at the same time.  You are in most cases going
to need to request the allocation of new pioctl numbers from the
registrar and implement the revised pioctl independently from the
existing implementation which might or might not be removed.

Jeffrey Altman


--------------enig2B823621B999F3225145D219
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

iQEcBAEBAgAGBQJMvd64AAoJENxm1CNJffh4inkIALDfQCeuBSDZlkfzHKmUr9LE
pyz1n4T21jFfcxNWJEHYGwl5ZNy9j1YvLGV2nmHKJQBfZ7rZzUwxEkVQk0bo4Tty
+KugJ/C+1ajbrwB/KcC6DNTj5YQTvOZGwgzemcWI8aAKFVCo2MAwctwiox5amQUu
AehAV6AQy/q/Lhq42CPjsnQM9Q1zXHwxjkBwIFtzmwg3IrRTUPaEftWTkkzjSeEj
2MwpXqTBvH985c1Ef1AYYhcqArYjgIMtJh7TEfTpI02hyNNghbojGOv8Xy3NTzsF
vXhrKF2ODhXBfoYXpsHEPHjiWn7oNRdpBaGLPkYugppDRVDjE2bhdWQv1d22je4=
=YSm2
-----END PGP SIGNATURE-----

--------------enig2B823621B999F3225145D219--