[OpenAFS-devel] Re: Change in openafs[master]: cmdebug -dcache
Hartmut Reuter
reuter@rzg.mpg.de
Mon, 24 Jan 2011 10:03:25 +0100
Simon Wilkinson (Code Review) wrote:
> Simon Wilkinson has posted comments on this change.
>
> Change subject: cmdebug -dcache
> ......................................................................
>
>
> Patch Set 1: (2 inline comments)
>
> The new GetDCacheEntry RPC and its associate structure needs to be
> standardised, and a proper code point allocated. It should be pretty easy to
> put together a draft describing this for the afs3-standardisation list.
Ok. Before spending much time on writing a draft I wanted to present this simple
addition just by showing the few lines of code.
>
> I'd also like to see some consideration of the security consequences of
> publishing the contents of the disk cache to anyone who asks, but that can be
> done as part of the standardisation discussion.
I think all the information about which files have been seen on the client are
already visible wich "cmdebug -long". The only additional information is which
chunks of the files are actually cached. Perhaps one could create a switch on
the client to disable both RPCs for sites which have security concerns.
>
> .................................................... File
> src/fsint/afscbint.xg Line 125: ) = 65540; Has this code point been allocated
> by the registrar?
Not yet, I first wanted to see the reaction of the community...
>
> .................................................... File
> src/fsint/common.xg Line 86: Whitespace
>
> -- To view, visit http://gerrit.openafs.org/3743 To unsubscribe, visit
> http://gerrit.openafs.org/settings
>
> Gerrit-MessageType: comment Gerrit-Change-Id:
> Ia7cb57bbc3686def297de4cacd3fcf519e4dd51f Gerrit-PatchSet: 1 Gerrit-Project:
> openafs Gerrit-Branch: master Gerrit-Owner: Hartmut
> Reuter<reuter@rzg.mpg.de> Gerrit-Reviewer:
> BuildBot<buildbot@rampaginggeek.com> Gerrit-Reviewer: Simon
> Wilkinson<sxw@inf.ed.ac.uk>
--
-----------------------------------------------------------------
Hartmut Reuter e-mail reuter@rzg.mpg.de
phone +49-89-3299-1328
fax +49-89-3299-1301
RZG (Rechenzentrum Garching) web http://www.rzg.mpg.de/~hwr
Computing Center of the Max-Planck-Gesellschaft (MPG) and the
Institut fuer Plasmaphysik (IPP)
-----------------------------------------------------------------