[OpenAFS-devel] Sanity check re: cmd_Seek
Derrick Brashear
shadow@gmail.com
Wed, 18 May 2011 22:29:25 -0400
--Apple-Mail-1-1047454591
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
On May 18, 2011, at 9:39 PM, Jeff Blaine <jblaine@kickflop.net> wrote:
> On 5/18/2011 9:14 PM, Derrick Brashear wrote:
>> basically you have some number of "slots" in the parm array which are
>> the switches. all this does is skip to a fixed offset before the next
>> AddParm is processed and thus fills a slot in the array.
>>
>> so the assumption here is no command has more than 12 of its own
>> parameters, and the "generic" flags can always be added from offset 12
>> onward.
>
> I think I get it.
>
> Above, "no command" = "no vos subcommand", right?
Yes
>
> And ultimately then for my changes I do not need to
> alter the offset the COMMONPARMS get fed to, but it
> would need to be altered if the decision was made to
> allow more than 12 arguments to one vos "subcommand"?
Yes
>
>> On Wed, May 18, 2011 at 9:10 PM, Jeff Blaine<jblaine@kickflop.net> wrote:
>>> Okay, I've made all -noexecute flags hidden, added
>>> -dryrun where there was a -noexecute, and normalized
>>> the help text for existing and new -dryrun args.
>>>
>>>
--Apple-Mail-1-1047454591
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
charset=utf-8
<html><body bgcolor=3D"#FFFFFF"><div><br><br></div><div><br>On May 18, 2011,=
at 9:39 PM, Jeff Blaine <<a href=3D"mailto:jblaine@kickflop.net">jblaine=
@kickflop.net</a>> wrote:<br><br></div><div></div><blockquote type=3D"cit=
e"><div><span>On 5/18/2011 9:14 PM, Derrick Brashear wrote:</span><br><block=
quote type=3D"cite"><span>basically you have some number of "slots" in the p=
arm array which are</span><br></blockquote><blockquote type=3D"cite"><span>t=
he switches. all this does is skip to a fixed offset before the next</span><=
br></blockquote><blockquote type=3D"cite"><span>AddParm is processed and thu=
s fills a slot in the array.</span><br></blockquote><blockquote type=3D"cite=
"><span></span><br></blockquote><blockquote type=3D"cite"><span>so the assum=
ption here is no command has more than 12 of its own</span><br></blockquote>=
<blockquote type=3D"cite"><span>parameters, and the "generic" flags can alwa=
ys be added from offset 12</span><br></blockquote><blockquote type=3D"cite">=
<span>onward.</span><br></blockquote><span></span><br><span>I think I get it=
.</span><br><span></span><br><span>Above, "no command" =3D "no vos subcomman=
d", right?</span><br></div></blockquote><div><br></div>Yes<br><blockquote ty=
pe=3D"cite"><div><span></span><br><span>And ultimately then for my changes I=
do not need to</span><br><span>alter the offset the COMMONPARMS get fed to,=
but it</span><br><span>would need to be altered if the decision was made to=
</span><br><span>allow more than 12 arguments to one vos "subcommand"?</span=
><br></div></blockquote><div><br></div>Yes<br><blockquote type=3D"cite"><div=
><span></span><br><blockquote type=3D"cite"><span>On Wed, May 18, 2011 at 9:=
10 PM, Jeff Blaine<<a href=3D"mailto:jblaine@kickflop.net">jblaine@kickfl=
op.net</a>> wrote:</span><br></blockquote><blockquote type=3D"cite"=
><blockquote type=3D"cite"><span>Okay, I've made all -noexecute flags hidden=
, added</span><br></blockquote></blockquote><blockquote type=3D"cite"><block=
quote type=3D"cite"><span>-dryrun where there was a -noexecute, and normaliz=
ed</span><br></blockquote></blockquote><blockquote type=3D"cite"><blockquote=
type=3D"cite"><span>the help text for existing and new -dryrun args.</span>=
<br></blockquote></blockquote><blockquote type=3D"cite"><blockquote type=3D"=
cite"><span></span><br></blockquote></blockquote><blockquote type=3D"cite"><=
blockquote type=3D"cite"><font class=3D"Apple-style-span" color=3D"#0023A3">=
<font class=3D"Apple-style-span" color=3D"#94000E"><br></font></font></block=
quote></blockquote></div></blockquote></body></html>=
--Apple-Mail-1-1047454591--