[OpenAFS-devel] Re: idle dead timeout processing in clients

Jeffrey Altman jaltman@secure-endpoints.com
Wed, 30 Nov 2011 14:06:34 -0500


This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigE09B11AA206B35C869E8F32A
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 11/30/2011 1:58 PM, Andrew Deason wrote:
> On Wed, 30 Nov 2011 18:48:47 +0000
> Simon Wilkinson <sxw@inf.ed.ac.uk> wrote:
>=20
>> The idle dead code isn't in any shipping versions of 1.4. Current 1.4
>> clients won't get RX_CALL_TIMEOUT, or RX_CALL_DEAD.
>=20
> I'm not sure if we're talking about completely different things or what=
=2E
> The afs_BlackListOnce code exists in (shipping) 1.4 and, I mean, it
> certainly gets _called_. If I insert a sleep(10000) into the FetchStatu=
s
> handler, the client will give an error (or failover to another site,
> etc); it won't just hang forever on the request.

That is not a valid simulation for this case.  Idle dead timeouts occur
when keepalives are being received but no actual data.

> And this exists in 1.4 rxi_CheckCall:
>=20
>     /* see if we have a non-activity timeout */
>     if (call->startWait && conn->idleDeadTime
>         && ((call->startWait + conn->idleDeadTime) < now) &&
>         (call->flags & RX_CALL_READER_WAIT)) {
>         if (call->state =3D=3D RX_STATE_ACTIVE) {
>             rxi_CallError(call, RX_CALL_TIMEOUT);
>             return -1;
>         }
>     }

Notice the RX_CALL_READER_WAIT check.  This is for server side
processing.  It is used by viced.  That code should remain.

Jeffrey Altman




--------------enigE09B11AA206B35C869E8F32A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

iQEcBAEBAgAGBQJO1n67AAoJENxm1CNJffh4Jy4H/28pIaEouxO7UYzPqjyQ90qO
EeAcMLZcegMuVRkPB0XR4AxwWm4PPvsQHFK+ahODByrldp8pNvOnJA19W89TJAkA
aslr3zkHokBVPgnDNUZ3E/0xpfiBqQKRJGelSxcsA6WBJ/dhR+3AceYR7Fcu7Jef
HPBybhKUeGfYjeT/v0e7AigpQ9S1E9Lozwa60AJDS+eu9I/88/3W0ATRENV7fDAd
jctO1JAyK/FigR8mXnzM2xAV6Uv4PR4IjHnoIdl129TNVBionPiOasKLoWxw6WjS
0uFoxAuFAL1kDrUYmCp1EpE0HgbO9ehywKtoRvL9EK5vW7aRFSjkuUIBIPW7eKw=
=gGih
-----END PGP SIGNATURE-----

--------------enigE09B11AA206B35C869E8F32A--