[OpenAFS-devel] glibc-2.16 support

Marc Dionne marc.c.dionne@gmail.com
Tue, 25 Sep 2012 07:47:53 -0400


On Tue, Sep 25, 2012 at 3:40 AM, Simon Wilkinson
<sxw@your-file-system.com> wrote:
>
> On 25 Sep 2012, at 07:55, Andrej Filipcic wrote:
>>
>> I have seen the <sys/resource.h> included in the HEAD, but not in openafs-stable-1_6_x branch. Can it be committed there as well?
>
> That's change bc3a32a8, from Marc Dionne.
>
> I've pushed a pullup of this change to gerrit at http://gerrit.openafs.org/8155. Providing this is approved, the change will be in a future 1.6 release.
>
> (Marc's change uses AFS_LINUX20_ENV, rather than HAVE_SYS_RESOURCE_H, to determine whether to include the sys/resource.h header. Your version is arguably cleaner, but changing the define would require modifying both master, and the 1.6 branch)

>From what I recall, the logic there was that a) that's the way it used
to be, with no HAVE_SYS_RESOURCE_H guard, and b) the bits that require
resource.h are only used within an AFS_LINUX20_ENV section.  So no
harm in making it more general or safer, but I don't think it's
needed.

Marc