[OpenAFS-devel] Pulling up changes to stable
Ben Huntsman
ben@huntsmans.net
Wed, 29 Mar 2023 16:29:28 +0000
--_000_MWHPR0701MB36749B2A8BF4ABE755B47091A7899MWHPR0701MB3674_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Hi there!
Thanks for the clarification, and apologies for the delay. Below are th=
e 5-digit change numbers from Gerrit that we'd need to pull up to a stable =
branch in order to fully support AIX:
15107
15116
15110
15112
15113
15114
15108
15119
15118
15122
15144
15145
15143
15146
15142
15310
15311
15312
Is there anything I can help do to get those incorporated into the next =
release?
Thank you so much!
-Ben
________________________________
From: Benjamin Kaduk <kaduk@mit.edu>
Sent: Saturday, March 4, 2023 6:37 PM
To: Ben Huntsman <ben@huntsmans.net>
Cc: Stephan Wiesand <stephan.wiesand@desy.de>; openafs-devel@openafs.org <o=
penafs-devel@openafs.org>
Subject: Re: [OpenAFS-devel] Pulling up changes to stable
The change number would be the 5-digit number from gerrit, but any of those
would work well enough to identify what you want.
-Ben
On Fri, Mar 03, 2023 at 11:36:47PM +0000, Ben Huntsman wrote:
> Hi Stephan!
> Thank you for the reply! I am happy to provide that information. To =
be clear, what are you looking for when you say "change numbers"? The 5-di=
git number from Gerrit? The Change-ID hash from the commit? Or the sha of=
the commit to master itself?
>
> Thank you again!
>
> -Ben
>
> ________________________________
> From: Stephan Wiesand <stephan.wiesand@desy.de>
> Sent: Friday, March 3, 2023 10:12 AM
> To: Ben Huntsman <ben@huntsmans.net>
> Cc: openafs-devel@openafs.org <openafs-devel@openafs.org>
> Subject: Re: [OpenAFS-devel] Pulling up changes to stable
>
> Hi Ben,
>
> > On 3. Mar 2023, at 18:13, Ben Huntsman <ben@huntsmans.net> wrote:
> >
> > Hi there!
> > Thank you for accepting the patches I submitted to get OpenAFS worki=
ng on AIX 7.2-7.3, as well as the previous ones!
>
> thank you for whipping those up.
>
> > Now that they're all there in the master branch, what needs to be do=
ne to pull them up into an upcoming stable branch?
>
> These changes are on my list of things I want to get into stable. I'm jus=
t slow.
>
> > I read the GitDevelopers page, but is it ok for anyone to push patche=
s to Gerrit for an upcoming stable, or is there some additional review proc=
ess?
>
> In principle it's ok, provided that those patches are clean cherry-picks =
from master. In practice, it causes extra work if a change pulled up like t=
his touches a file already modified by any other change in the queue. In ad=
dition, you'll sometimes (or rather often) find that the change from master=
doesn't apply cleanly to stable, and either needs to be modified or (prefe=
rrably) be supplemented by more changes from master not yet on stable.
>
> Mind you, you're absolutely free to submit those pull-ups yourself. The m=
ost appreciated way you can help though is to provide a list of change numb=
ers you'd like to see in an upcoming stable release. And keep poking...
>
> Best regards,
> Stephan
>
> >
> > Thank you much!
> >
> > -Ben
>
>
> --
> Stephan Wiesand
> DESY - DV -
> Platanenallee 6
> 15738 Zeuthen, Germany
>
>
>
--_000_MWHPR0701MB36749B2A8BF4ABE755B47091A7899MWHPR0701MB3674_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dus-ascii"=
>
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
Hi there!</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
Thanks for the clarification, and apologies for the delay=
. Below are the 5-digit change numbers from Gerrit that we'd need to =
pull up to a stable branch in order to fully support AIX:</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof ContentPasted0">
15107
<div class=3D"ContentPasted0">15116</div>
<div class=3D"ContentPasted0">15110</div>
<div class=3D"ContentPasted0">15112</div>
<div class=3D"ContentPasted0">15113</div>
<div class=3D"ContentPasted0">15114</div>
<div class=3D"ContentPasted0">15108</div>
<div class=3D"ContentPasted0">15119</div>
<div class=3D"ContentPasted0">15118</div>
<div class=3D"ContentPasted0">15122</div>
<div class=3D"ContentPasted0">15144</div>
<div class=3D"ContentPasted0">15145</div>
<div class=3D"ContentPasted0">15143</div>
<div class=3D"ContentPasted0">15146</div>
<div class=3D"ContentPasted0">15142</div>
<div class=3D"ContentPasted0">15310</div>
<div class=3D"ContentPasted0">15311</div>
<div class=3D"ContentPasted0">15312</div>
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof ContentPasted0">
Is there anything I can help do to get those incorporated into=
the next release?</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof ContentPasted0">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof ContentPasted0">
Thank you so much!</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof ContentPasted0">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof ContentPasted0">
-Ben</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class=
=3D"elementToProof ContentPasted0">
<br>
</div>
<div id=3D"appendonsend"></div>
<hr style=3D"display:inline-block;width:98%" tabindex=3D"-1">
<div id=3D"divRplyFwdMsg" dir=3D"ltr"><font face=3D"Calibri, sans-serif" st=
yle=3D"font-size:11pt" color=3D"#000000"><b>From:</b> Benjamin Kaduk <ka=
duk@mit.edu><br>
<b>Sent:</b> Saturday, March 4, 2023 6:37 PM<br>
<b>To:</b> Ben Huntsman <ben@huntsmans.net><br>
<b>Cc:</b> Stephan Wiesand <stephan.wiesand@desy.de>; openafs-devel@o=
penafs.org <openafs-devel@openafs.org><br>
<b>Subject:</b> Re: [OpenAFS-devel] Pulling up changes to stable</font>
<div> </div>
</div>
<div class=3D"BodyFragment"><font size=3D"2"><span style=3D"font-size:11pt;=
">
<div class=3D"PlainText">The change number would be the 5-digit number from=
gerrit, but any of those<br>
would work well enough to identify what you want.<br>
<br>
-Ben<br>
<br>
On Fri, Mar 03, 2023 at 11:36:47PM +0000, Ben Huntsman wrote:<br>
> Hi Stephan!<br>
> Thank you for the reply! I am happy to provide=
that information. To be clear, what are you looking for when you say=
"change numbers"? The 5-digit number from Gerrit? Th=
e Change-ID hash from the commit? Or the sha of the commit to master =
itself?<br>
> <br>
> Thank you again!<br>
> <br>
> -Ben<br>
> <br>
> ________________________________<br>
> From: Stephan Wiesand <stephan.wiesand@desy.de><br>
> Sent: Friday, March 3, 2023 10:12 AM<br>
> To: Ben Huntsman <ben@huntsmans.net><br>
> Cc: openafs-devel@openafs.org <openafs-devel@openafs.org><br>
> Subject: Re: [OpenAFS-devel] Pulling up changes to stable<br>
> <br>
> Hi Ben,<br>
> <br>
> > On 3. Mar 2023, at 18:13, Ben Huntsman <ben@huntsmans.net> =
wrote:<br>
> ><br>
> > Hi there!<br>
> > Thank you for accepting the patches I submitted=
to get OpenAFS working on AIX 7.2-7.3, as well as the previous ones!<br>
> <br>
> thank you for whipping those up.<br>
> <br>
> > Now that they're all there in the master branch=
, what needs to be done to pull them up into an upcoming stable branch?<br>
> <br>
> These changes are on my list of things I want to get into stable. I'm =
just slow.<br>
> <br>
> > I read the GitDevelopers page, but is it ok for anyon=
e to push patches to Gerrit for an upcoming stable, or is there some additi=
onal review process?<br>
> <br>
> In principle it's ok, provided that those patches are clean cherry-pic=
ks from master. In practice, it causes extra work if a change pulled up lik=
e this touches a file already modified by any other change in the queue. In=
addition, you'll sometimes (or rather
often) find that the change from master doesn't apply cleanly to stable, a=
nd either needs to be modified or (preferrably) be supplemented by more cha=
nges from master not yet on stable.<br>
> <br>
> Mind you, you're absolutely free to submit those pull-ups yourself. Th=
e most appreciated way you can help though is to provide a list of change n=
umbers you'd like to see in an upcoming stable release. And keep poking...<=
br>
> <br>
> Best regards,<br>
> Stephan<br>
> <br>
> ><br>
> > Thank you much!<br>
> ><br>
> > -Ben<br>
> <br>
> <br>
> --<br>
> Stephan Wiesand<br>
> DESY - DV -<br>
> Platanenallee 6<br>
> 15738 Zeuthen, Germany<br>
> <br>
> <br>
> <br>
</div>
</span></font></div>
</body>
</html>
--_000_MWHPR0701MB36749B2A8BF4ABE755B47091A7899MWHPR0701MB3674_--