[OpenAFS-devel] Openafs on kernel 6.14 Fedora 42 patched but fails to compile

Eric Matlis ematlis@nd.edu
Mon, 21 Apr 2025 16:31:37 -0400


--000000000000e77d8606334fc14d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

When I try to apply this most recent patch, it fails here:

matlis@aspire:~/Downloads/z.openafs-patched/openafs-1.8.13.2$ patch -p1
<d065da8.diff
patching file acinclude.m4
can't find file to patch at input line 67
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/doc/process/code-style-guide.md
b/doc/process/code-style-guide.md
|index a2c4dd8..ab0b24f 100644
|--- a/doc/process/code-style-guide.md
|+++ b/doc/process/code-style-guide.md
--------------------------
File to patch:

Even after expanding the .doc.tar.gz, I don't see this file:
doc/process/code-style-guide.md

The sources I'm trying to patch are the 1.8.13.2 tar files at openafs.org.
**********************************************
Eric Matlis
Associate Research Professor
114 Hessert Laboratory
Aerospace and Mechanical Engineering
University of Notre Dame
Notre Dame, IN
574-631-6054


On Mon, Apr 21, 2025 at 3:35=E2=80=AFPM Cheyenne Wills <cwills@sinenomine.n=
et>
wrote:

> I've pushed a change to gerrit that addresses this problem
> (https://gerrit.openafs.org/16367).  The change will need to go through
> the normal review process.
>
> --
> Cheyenne Wills
> cwills@sinenomine.net
>
>
>
> On Fri, 18 Apr 2025 11:43:15 -0400
> Eric Matlis <ematlis@nd.edu> wrote:
> > Dear developers-
> >
> > patches https://gerrit.openafs.org/#/c/16277/ and
> > https://gerrit.openafs.org/#/c/16276/1 fail to fix openafs-1.8.13.2
> > for compilation under Fedora 42 and kernel 6.14.2-300.  The error I
> > get using rpmbuild is:
> >
> > iomgr.c:50:23: error: =E2=80=98bool=E2=80=99 cannot be defined via =E2=
=80=98typedef=E2=80=99
> >   50 | typedef unsigned char bool;
> >      |                       ^~~~
> > iomgr.c:50:23: note: =E2=80=98bool=E2=80=99 is a keyword with =E2=80=98=
-std=3Dc23=E2=80=99 onwards
> > iomgr.c:50:1: warning: useless type name in empty declaration
> >   50 | typedef unsigned char bool;
> >
> > This was after applying the patches manually with "patch -p1 <
> > patchfile" to the source code extracted from the bunzip2 tar file,
> > recreating the tar file, executing the procedure to turn tar files
> > into a src rpm, and issuing "rpmbuild --rebuild xxx.src.rpm".
> >
> > Let me know if I can provide any other information.
> >
> > Thank you and please advise,
> > Eric
> >
> > **********************************************
> > Eric Matlis
> > Associate Research Professor
> > 114 Hessert Laboratory
> > Aerospace and Mechanical Engineering
> > University of Notre Dame
> > Notre Dame, IN
> > 574-631-6054
>
>

--000000000000e77d8606334fc14d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>When I try to apply this most recent patch, it fails =
here:</div><div><br></div><div><span style=3D"font-family:monospace"><span =
style=3D"color:rgb(24,178,24)">matlis@aspire</span><span style=3D"color:rgb=
(0,0,0)">:</span><span style=3D"color:rgb(24,178,24)">~/Downloads/z.openafs=
-patched/openafs-1.8.13.2</span><span style=3D"color:rgb(0,0,0)">$ patch -p=
1 &lt;d065da8.diff </span><span style=3D"color:rgb(0,0,0)">=C2=A0</span><br=
><span style=3D"color:rgb(0,0,0)">patching file acinclude.m4</span><span st=
yle=3D"color:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">can&#39;t find file to patch at=
 input line 67</span><span style=3D"color:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">Perhaps you used the wrong -p o=
r --strip option?</span><span style=3D"color:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">The text leading up to this was=
:</span><span style=3D"color:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">--------------------------</spa=
n><span style=3D"color:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">|diff --git a/doc/process/code-=
style-guide.md b/doc/process/code-style-guide.md</span><span style=3D"color=
:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">|index a2c4dd8..ab0b24f 100644<=
/span><span style=3D"color:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">|--- a/doc/process/code-style-g=
uide.md</span><span style=3D"color:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">|+++ b/doc/process/code-style-g=
uide.md</span><span style=3D"color:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">--------------------------</spa=
n><span style=3D"color:rgb(0,0,0)">
</span><br><span style=3D"color:rgb(0,0,0)">File to patch:</span><br></span=
></div><div><span style=3D"font-family:monospace"><br></span></div><div><sp=
an style=3D"font-family:monospace">Even after expanding the .doc.tar.gz, I =
don&#39;t see this file:=C2=A0</span>doc/process/code-style-guide.md</div><=
div><br></div><div>The sources I&#39;m trying to patch are the 1.8.13.2 tar=
 files at <a href=3D"http://openafs.org">openafs.org</a>.</div><div><div di=
r=3D"ltr" class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div=
 dir=3D"ltr"><div><div dir=3D"ltr"><div>***********************************=
***********</div><div>Eric Matlis</div><div>Associate Research Professor</d=
iv><div>114 Hessert Laboratory</div><div>Aerospace and Mechanical Engineeri=
ng</div><div>University of Notre Dame</div><div>Notre Dame, IN</div><div>57=
4-631-6054</div></div></div></div></div></div><br></div><br><div class=3D"g=
mail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On =
Mon, Apr 21, 2025 at 3:35=E2=80=AFPM Cheyenne Wills &lt;<a href=3D"mailto:c=
wills@sinenomine.net">cwills@sinenomine.net</a>&gt; wrote:<br></div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex">I&#39;ve pushed a change to gerr=
it that addresses this problem<br>
(<a href=3D"https://gerrit.openafs.org/16367" rel=3D"noreferrer" target=3D"=
_blank">https://gerrit.openafs.org/16367</a>).=C2=A0 The change will need t=
o go through<br>
the normal review process.<br>
<br>
-- <br>
Cheyenne Wills<br>
<a href=3D"mailto:cwills@sinenomine.net" target=3D"_blank">cwills@sinenomin=
e.net</a><br>
<br>
<br>
<br>
On Fri, 18 Apr 2025 11:43:15 -0400<br>
Eric Matlis &lt;<a href=3D"mailto:ematlis@nd.edu" target=3D"_blank">ematlis=
@nd.edu</a>&gt; wrote:<br>
&gt; Dear developers-<br>
&gt; <br>
&gt; patches <a href=3D"https://gerrit.openafs.org/#/c/16277/" rel=3D"noref=
errer" target=3D"_blank">https://gerrit.openafs.org/#/c/16277/</a> and<br>
&gt; <a href=3D"https://gerrit.openafs.org/#/c/16276/1" rel=3D"noreferrer" =
target=3D"_blank">https://gerrit.openafs.org/#/c/16276/1</a> fail to fix op=
enafs-1.8.13.2<br>
&gt; for compilation under Fedora 42 and kernel 6.14.2-300.=C2=A0 The error=
 I<br>
&gt; get using rpmbuild is:<br>
&gt; <br>
&gt; iomgr.c:50:23: error: =E2=80=98bool=E2=80=99 cannot be defined via =E2=
=80=98typedef=E2=80=99<br>
&gt;=C2=A0 =C2=A050 | typedef unsigned char bool;<br>
&gt;=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~<br>
&gt; iomgr.c:50:23: note: =E2=80=98bool=E2=80=99 is a keyword with =E2=80=
=98-std=3Dc23=E2=80=99 onwards<br>
&gt; iomgr.c:50:1: warning: useless type name in empty declaration<br>
&gt;=C2=A0 =C2=A050 | typedef unsigned char bool;<br>
&gt; <br>
&gt; This was after applying the patches manually with &quot;patch -p1 &lt;=
<br>
&gt; patchfile&quot; to the source code extracted from the bunzip2 tar file=
,<br>
&gt; recreating the tar file, executing the procedure to turn tar files<br>
&gt; into a src rpm, and issuing &quot;rpmbuild --rebuild xxx.src.rpm&quot;=
.<br>
&gt; <br>
&gt; Let me know if I can provide any other information.<br>
&gt; <br>
&gt; Thank you and please advise,<br>
&gt; Eric<br>
&gt; <br>
&gt; **********************************************<br>
&gt; Eric Matlis<br>
&gt; Associate Research Professor<br>
&gt; 114 Hessert Laboratory<br>
&gt; Aerospace and Mechanical Engineering<br>
&gt; University of Notre Dame<br>
&gt; Notre Dame, IN<br>
&gt; 574-631-6054<br>
<br>
</blockquote></div>

--000000000000e77d8606334fc14d--