[OpenAFS-Doc] salvager man page typo

Michael Meffie mmeffie@sinenomine.net
Fri, 06 Feb 2009 12:30:28 -0500


Jeffrey Altman wrote:
> Jason Edgecombe wrote:
>>>            Specifies the maximum number of Salvager subprocesses to
>>>            run in parallel. Provide one of three values:
>>>
>>>            *   An integer from the range 1 to 32. A value of 1 means
>>>                that a single Salvager process salvages the
>>>                partitions sequentially.
>>>
>>>            *   The string "all" to run up to four Salvager
>>>                subprocesses in parallel on partitions formatted as
>>>                logical volumes that span multiple physical disks.
>>>                Use this value only with such logical volumes.
>>>
>>>            *   The string "all" followed immediately (with no
>>>                intervening space) by an integer from the range 1 to
>>>                32, to run the specified number of Salvager
>>>                subprocesses in parallel on partitions formatted as
>>>                logical volumes. Use this value only with such
>>>                logical volumes.
>>>
>>>
>> What is the difference between 5 and all5? If there is no difference,
>> then I suggest removing the "all#" verbiage from the man page.
> 
> There are two variables being set:
> 
> 'Parallel' which defaults to 4 and has a valid range of 1..32
> 
> 'PartsPerDisk' which defaults to 8 and is set to 1 if the prefix of the
> -parallel parameter is the string "all"
> 
> 'Parallel' determines the number of simultaneous salvager processes are
> executed.
> 'PartsPerDisk' determines the degree of parallelism.  Without specifying
> "all" and setting 'PartsPerDisk' to 1, each salvager process will
> salvage partitions on the same logical volume in sequential order. 
> 
> Prepending "all" to the parameter treats every partition as a logical
> volume and permits more than one salvager process to operate on the same
> physical disks.
> 
> I doubt that was clearer for end users but perhaps it will enable one of
> you to write text that makes sense.

Russ committed a fix for this issue,

http://openafs.org/cgi-bin/wdelta/MAIN/man-page-salvager-fixes-20090201

Thank you Russ.
Mike