[OpenAFS-Doc] salvager man page typo
Jason Edgecombe
jason@rampaginggeek.com
Wed, 28 Jan 2009 20:23:37 -0500
Michael Meffie wrote:
> Hello list,
>
> I noticed a typo on the salvager man page, and that Harald Barth has
> already
> opened a ticket for it. See ticket 99838.
>
> Would the correction just be, ?
>
> --- doc/man-pages/pod8/salvager.pod 1 Mar 2006 05:11:28
> -0000 1.3.2.5
> +++ doc/man-pages/pod8/salvager.pod 27 Jan 2009 20:56:53 -0000
> @@ -104,7 +104,7 @@
> logical volumes that span multiple disks. To force the Salvager to
> salvage
> logical volumes in parallel, provide the string C<all> as the value for
> the B<-parallel> argument. Provide a positive integer to specify the
> -number of subprocesses to run in parallel (for example, C<-parallel
> 5all>
> +number of subprocesses to run in parallel (for example, C<-parallel
> all5>
> for five subprocesses), or omit the integer to run up to four
> subprocesses, depending on the number of logical volumes being salvaged.
>
>
> "-parallel 5all" doesn't make sense if you look at the salvager code.
> The "all" string it skipped if present, then number is read. ("5all"
> is interpeted as just "5", but that is just an accident of the
> implementation.)
>
> This agrees with the man page description of -parallel, which is,
>
> -parallel <# of max parallel partition salvaging>
>
> Specifies the maximum number of Salvager subprocesses to
> run in parallel. Provide one of three values:
>
> * An integer from the range 1 to 32. A value of 1 means
> that a single Salvager process salvages the
> partitions sequentially.
>
> * The string "all" to run up to four Salvager
> subprocesses in parallel on partitions formatted as
> logical volumes that span multiple physical disks.
> Use this value only with such logical volumes.
>
> * The string "all" followed immediately (with no
> intervening space) by an integer from the range 1 to
> 32, to run the specified number of Salvager
> subprocesses in parallel on partitions formatted as
> logical volumes. Use this value only with such
> logical volumes.
>
>
What is the difference between 5 and all5? If there is no difference,
then I suggest removing the "all#" verbiage from the man page.
Jason