[OpenAFS] Re: 1.3.70 comments?

Derrick J Brashear shadow@dementia.org
Thu, 19 Aug 2004 02:11:51 -0400 (EDT)


On Thu, 19 Aug 2004, Derrick J Brashear wrote:

> On Wed, 18 Aug 2004, Steve Roseman wrote:
>
>> CRASH INFORMATION:
>> CPU 0 CSA F002FBE0 at time of crash, error code for LEDs: 30000000
>> pvthread+000480 STACK:
>> [00009518].simple_lock+000018 ()
>> [057AE918]rxi_ResetCall+0000EC (30B65474, 00000000)
>
> looking at what mutexes can be in play here, i'm going to have to bet on 
> peer->peer_lock. the rest are init'd in rx_InitHost (rx_Init), which seeing 
> as we have a kernel rx listener, well, it must have run. likewise, only 
> shutdown_rx kills said mutexes.

Ok, this obviously isn't a fix, but it will tell us if we're on the path 
of the right problem (at least if you can reinit an init'd already lock 
without panicing)
--- rx.c        19 Aug 2004 00:41:54 -0000      1.60
+++ rx.c        19 Aug 2004 06:11:44 -0000
@@ -5725,7 +5725,7 @@
                     rx_interface_stat_p rpc_stat, nrpc_stat;
                     size_t space;
                     MUTEX_EXIT(&peer->peer_lock);
-                   MUTEX_DESTROY(&peer->peer_lock);
+                   /*MUTEX_DESTROY(&peer->peer_lock);*/
                     for (queue_Scan
                          (&peer->rpcStats, rpc_stat, nrpc_stat,
                           rx_interface_stat)) {