[OpenAFS] (1.3.72 - RHEL 3 Linux) function declaration issues in src/vol/nuke.c

[Murray Anderegg]

This is a multi-part message in MIME format.
--------------090909040105070401000808
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

gcc -pipe  -O2 -I/usr/src/redhat/BUILD/openafs-1.3.72/src/config -I. -I. 
-I/usr/src/redhat/BUILD/openafs-1.3.72/include 
-I/usr/src/redhat/BUILD/openafs-1.3.72/include/afs 
-I/usr/src/redhat/BUILD/openafs-1.3.72/include/rx 
-I/usr/src/redhat/BUILD/openafs-1.3.72 
-I/usr/src/redhat/BUILD/openafs-1.3.72/src 
-I/usr/src/redhat/BUILD/openafs-1.3.72/src -Di386_linux24  -g -O2 
-D_LARGEFILE64_SOURCE -c nuke.cnuke.c: In function `nuke':
nuke.c:172: warning: passing arg 4 of `ListViceInodes' from incompatible 
pointer type
nuke.c:172: too few arguments to function `ListViceInodes'
make[3]: *** [nuke.o] Error 1
make[3]: Leaving directory `/usr/src/redhat/BUILD/openafs-1.3.72/src/vol'
make[2]: *** [vol] Error 2
make[2]: Leaving directory `/usr/src/redhat/BUILD/openafs-1.3.72'
make[1]: *** [build] Error 2
make[1]: Leaving directory `/usr/src/redhat/BUILD/openafs-1.3.72'
make: *** [all_nolibafs] Error 2

Here is the call to ListViceInodes:

   code =
        ListViceInodes(lastDevComp, aname, NULL, NukeProc, avolid, 
&forceSal,
                       0, wpath);

Here is the declaration of ListViceInodes in namei_ops.h:

int ListViceInodes(char *devname, char *mountedOn, char *resultFile,
                   int (*judgeInode) (struct ViceInodeInfo * info, int vid,
                                      void *rock),
                   int singleVolumeNumber, int *forcep, int forceR,
                   char *wpath, void *rock);
 
rock is getting passed in to judgeInode.

ListViceInodes shows up in the following files in src/vol:
# grep -l ListViceInodes *.c *.h
listinodes.c
namei_ops.c
ntops.c
nuke.c
vol-salvage.c
namei_ops.h
ntops.h

I'm going to try and figure out how which way to implement the fix for 
ListViceInodes...

Attached find a patch to be run as patch -p1 for a compile error in des.c


--------------090909040105070401000808
Content-Type: text/plain;
 name="openafs-1.3.72-des-prototype2.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="openafs-1.3.72-des-prototype2.patch"

--- openafs-1.3.72/src/des/des_prototypes.h.orig	2004-10-18 03:11:56.000000000 -0400
+++ openafs-1.3.72/src/des/des_prototypes.h	2004-10-18 08:40:41.000000000 -0400
@@ -30,7 +30,7 @@
 				  int encrypt);
 
 /* des.c */
-extern afs_int32 des_ecb_encrypt(void * clear, void * cipher,
+extern afs_int32 des_ecb_encrypt(afs_uint32 * clear, afs_uint32 * cipher,
 				 register des_key_schedule schedule,
 				 int encrypt);
 

--------------090909040105070401000808--