[OpenAFS] fstat vs stat in 1.3.82

Jim Rees rees@umich.edu
Fri, 10 Jun 2005 10:51:01 -0400


It's actually worse than that.  This code makes no sense at all:

	&& (!(fstat(AFSDIR_BOZLOG_FILE, &sb) == 0) && 
	(S_ISFIFO(sb.st_mode)))

Even if you change it to stat, what it seems to be saying (in a very
ofuscated way) is, "if the file doesn't exist and is a fifo."  If it doesn't
exist, it certainly isn't a fifo.  I'll bet the contents of sb aren't even
defined at this point.

I'll go out on a limb here and guess that this is left over from a time when
the log file was kept open and no longer serves a useful purpose.  I vote to
remove it.