[OpenAFS] Problems with OpenAFS 1.4.1.

[Russ Allbery]

Rainer Toebbicke <rtb@pclella.cern.ch> writes:

> I might have misunderstood as it was a bit long... but if you're backing
> up on a x86_64 Linux then you need the attached patch.

> It's in CVS (DELTA backup-dump-parameter-fix-20060411), but wasn't yet
> in 1.4.1. (another integer passed when a pointer was intended).

> --- openafs/src/bucoord/commands.c.o141	2005-07-11 21:29:33.000000000 +0200
> +++ openafs/src/bucoord/commands.c	2006-04-11 17:27:09.000000000 +0200
> @@ -1964,7 +1964,7 @@
>      code = bc_StartDmpRst(bc_globalConfig, dumpPath, vsName, volsToDump,
>  			  /*destServer */ 0, /*destPartition */ 0,
>  			  /*fromDate */ 0,
> -			  /*newExt */ 0, /*oldFlag */ 0,
> +			  /*newExt */ NULL, /*oldFlag */ 0,
>  			  parent, level, bc_Dumper, portp, /*portCount */ 1,
>  			  baseds, doAppend, dontExecute);
>      if (code)

Ugh.

Prototypes are good.  Prototypes mean that you don't have to worry about
things like that.  We really need to prototype all the public interfaces.

-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>