[OpenAFS] problem with long vos dump filenames on linux (possible
buffer overflow?)
Derrick J Brashear
shadow@dementia.org
Wed, 9 May 2007 20:06:09 -0400 (EDT)
You copied openafs-bugs. Please don't. Send twice.
On Wed, 9 May 2007, Stephen Joyce wrote:
> Is there a known filename limit on vos dump pathnames? This behavior seems
> undesirable.
volser.h:#define NameLen 80
volser.p.h:#define NameLen 80
vos.c: char filename[NameLen];
vos.c: char afilename[NameLen], avolname[VOLSER_MAXVOLNAME + 1], apartName[10];
Yeah, this is dumb, it's being misapplied. This isn't going over the
network. It should be MAXPATHLEN in both cases. Perhaps whatever came
before usd_Open/USD_CLOSE was dumb. We lack source history.