[OpenAFS] Bug in pts/ptserver: createuser with a negative id works

Steve Simmons scs@umich.edu
Fri, 15 Oct 2010 15:12:59 -0400


On Oct 15, 2010, at 3:09 PM, Jeffrey Altman wrote:

> On 10/15/2010 3:05 PM, Phillip Moore wrote:
>> While adding test cases for failures in the AFS::Command::PTS test
>> suite, I noticed the following unexpected results:
>>=20
>> [root@rpcore ~]# pts createuser -name fakeafscmduser -id -1010 -cell
>> a.rp.nyc.us.test.efs
>> User fakeafscmduser has id -1010
>> [root@rpcore ~]# pts creategroup -name fakeafscmdgroup -id 510 -cell
>> a.rp.nyc.us.test.efs
>> pts: argument illegal or out of range because group id 510 was not =
negative
>>=20
>> At the very least, this assymetry suggests that one these is wrong.  =
My
>> vote is that createuser is broken, and should be producing the same =
type
>> of error as creategroup does when the opposite mistake is made.
>>=20
>> The resulting pts ID looks like a normal group, FWIW:
>>=20
>> [root@rpcore ~]# pts examine fakeafscmduser
>> Name: fakeafscmduser, id: -1010, owner: afsadmin, creator: afsadmin,
>>  membership: 0, flags: S-M--, group quota: 0.
>>=20
>> This is using OpenAFS 1.5.77, and I don't have handy access to an =
older
>> cell to test this.=20
>=20
> Creatuser is broken.  Please send bugs to openafs-bugs@openafs.org

pts createuser successfully uses negative uids and creates a group in =
1.4.11.