[OpenAFS] Re: 1.6.0-pre2 ptserver/vlserver dumping core

Ryan C. Underwood nemesis@icequake.net
Wed, 2 Mar 2011 14:17:18 -0600


On Wed, Mar 02, 2011 at 12:19:12PM -0600, Andrew Deason wrote:
> On Wed, 2 Mar 2011 00:04:50 -0600
> Andrew Deason <adeason@sinenomine.net> wrote:
> 
> > Looking at it a bit more... one thing that seems odd is that we don't
> > ever seem to cancel the GrowMTU event. Shouldn't we be doing that in
> > FreeCall/ResetCall/EndCall somewhere? It seems like we could have some
> > other event go the CheckCall->FreeCall->DestroyConn route while the
> > GrowMTUEvent is still pending, and when the GrowMTUEvent fires, it
> > follows the same path and frees the conn again. That wouldn't be a
> > problem in the pthreaded case because we check the call refs before
> > freeing in CheckCall.
> 
> I'm inferring Derrick agrees with this, from gerrit 4108 :). Ryan, if
> you would like to try this patch:
> <http://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=f82277b98404bc35a28e4d9ae2d084e37b3f9d7c>
> (it will apply with some line offsets) It would be nice to see if that
> solves the issue.

So far, so good.

-- 
Ryan C. Underwood, <nemesis@icequake.net>