[OpenAFS] Current "balance" practice?

Benjamin Kaduk kaduk@mit.edu
Sun, 2 Dec 2018 18:59:37 -0600


On Sat, Dec 01, 2018 at 04:29:29AM +0000, Chaskiel Grundman wrote:
> >> The vsu_ClientInit() signature change was a side-effect of the
> >> refactoring of ugen_ClientInit().  No one remembered the possible out of
> >> tree usage of vsu_ClientInit().  vsu_ClientInit() is not an exported
> >> function.  As such its status as public is murky at best.
> >
> >Indeed, I use the export symbol lists for the public shared libraries to
> >determine what standard of review to apply to API changes, and non-exported
> >symbols mostly get a free-for-all for API changes.
> 
> If that's how the world works, then commit to it, and don't publish the related archive libraries or headers anymore. I guess this is already in progress, as the prototypes for UV_* functions used by balance and backup clients  (in volser_prototypes.h and volser_internal.h) are not part of distributions.

It's definitely something to think about for 2.0, yes.

> The "public" shared libraries started life as "what the threaded fileserver and windows processes running in the service manager need from rx/rxkad/des/comerr" and "what the threaded fileserver needed from afsconf" + "what libadmin needed from the kaserver client". Only people who really cared about getting rid of LWP would have tried to migrate to them from the old archive libraries.

Fair points all.

Thanks,

Ben