[OpenAFS-port-freebsd] Build broken on 8.1

[Benjamin Kaduk]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---559023410-1387573002-1311448308=:7526
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Sat, 23 Jul 2011, Garrett Wollman wrote:

> The build has been broken on 8.1 for a few days now.  Here's the
> error:
>
> gcc -I. -I.. -I../nfs  -I/usr/home/buildbot/buildslave/freebsd81-amd64/bu=
ild/src/crypto/hcrypto/kernel  -I/usr/home/buildbot/buildslave/freebsd81-am=
d64/build/src  -I/usr/home/buildbot/buildslave/freebsd81-amd64/build/src/af=
s  -I/usr/home/buildbot/buildslave/freebsd81-amd64/build/src/afs/FBSD  -I/u=
sr/home/buildbot/buildslave/freebsd81-amd64/build/src/config  -I/usr/home/b=
uildbot/buildslave/freebsd81-amd64/build/src/rx/FBSD  -I/usr/home/buildbot/=
buildslave/freebsd81-amd64/build/src/external/heimdal  -I/usr/home/buildbot=
/buildslave/freebsd81-amd64/build/src  -I/usr/home/buildbot/buildslave/free=
bsd81-amd64/build/src/afs  -I/usr/home/buildbot/buildslave/freebsd81-amd64/=
build/src/afs/FBSD  -I/usr/home/buildbot/buildslave/freebsd81-amd64/build/s=
rc/config  -I/usr/home/buildbot/buildslave/freebsd81-amd64/build/src/fsint =
 -I/usr/home/buildbot/buildslave/freebsd81-amd64/build/src/vlserver  -I/usr=
/home/buildbot/buildslave/freebsd81-amd64/build/src/auth  -I/usr/home/build=
bot/buildslave/freebsd81-amd64/build/include  -I/usr/home/buildbot/buildsla=
ve/freebsd81-amd64/build/include/afs  -O -DAFSDEBUG -DKERNEL -DAFS -DVICE -=
DNFS -DUFS -DINET -DQUOTA -DGETMOUNT -Werror -D_KERNEL -DKLD_MODULE -nostdi=
nc  -I. -I.. -I../nfs -I/usr/home/buildbot/buildslave/freebsd81-amd64/build=
/src/crypto/hcrypto/kernel -I/usr/home/buildbot/buildslave/freebsd81-amd64/=
build/src -I/usr/home/buildbot/buildslave/freebsd81-amd64/build/src/afs -I/=
usr/home/buildbot/buildslave/freebsd81-amd64/build/src/afs/FBSD -I/usr/home=
/buildbot/buildslave/freebsd81-amd64/build/src/config -I/usr/home/buildbot/=
buildslave/freebsd81-amd64/build/src/rx/FBSD -I/usr/home/buildbot/buildslav=
e/freebsd81-amd64/build/src/external/heimdal -I/usr/home/buildbot/buildslav=
e/freebsd81-amd64/build/src -I/usr/home/buildbot/buildslave/freebsd81-amd64=
/build/src/afs -I/usr/home/buildbot/buildslave/freebsd81-amd64/build/src/af=
s/FBSD -I/usr/home/buildbot/buildslave/freebsd81-amd64/build/src/config -I/=
usr/home/buildbot/buildslave/freebsd81-amd64/build/src/fsint -I/usr/home/bu=
ildbot/buildslave/freebsd81-amd64/build/src/vlserver -I/usr/home/buildbot/b=
uildslave/freebsd81-amd64/build/src/auth -I/usr/home/buildbot/buildslave/fr=
eebsd81-amd64/build/include -I/usr/home/buildbot/buildslave/freebsd81-amd64=
/build/include/afs -I@/sys -Imachine -I. -I@ -I@/contrib/altq -finline-limi=
t=3D8000 --param inline-unit-growth=3D100 --param large-function-growth=3D1=
000 -fno-common  -fno-omit-frame-pointer -mcmodel=3Dkernel -mno-red-zone  -=
mfpmath=3D387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow  -msoft-floa=
t -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=3Di=
so9899:1999 -fstack-protector -Wno-redundant-decls -Wsystem-headers -Werror=
 -Wno-pointer-sign -DAFS_NONFSTRANS -DAFS_WRAPPER=3Dlibafs.ko_wrapper -DAFS=
_CONF_DATA=3Dlibafs.ko_conf_data -o osi_vfsops.o -c /usr/home/buildbot/buil=
dslave/freebsd81-amd64/build/src/afs/FBSD/osi_vfsops.c
> cc1: warnings being treated as errors
> /usr/home/buildbot/buildslave/freebsd81-amd64/build/src/afs/FBSD/osi_vfso=
ps.c: In function 'afs_init':
> /usr/home/buildbot/buildslave/freebsd81-amd64/build/src/afs/FBSD/osi_vfso=
ps.c:59: warning: comparison of distinct pointer types lacks a cast
> /usr/home/buildbot/buildslave/freebsd81-amd64/build/src/afs/FBSD/osi_vfso=
ps.c:59: warning: comparison of distinct pointer types lacks a cast

Hi Garrett,

Thanks for the report -- this is fallout from bsd.kmod.mk enabling=20
-Werror, but wasn't caught on my machine running HEAD due to the #ifdefs=20
in afs_init.  The fix should be pretty simple -- see gerrit/5087

-Ben
---559023410-1387573002-1311448308=:7526--