[AFS3-std] struct uvldbentry field spares1 -> matchindex

Derrick Brashear shadow@gmail.com
Tue Apr 13 15:54:00 EDT 2010


Oh crap. The registrar was a real CC and not a BCC. Sorry.

Well, please don't reply-all to the registrar.

On Tue, Apr 13, 2010 at 3:53 PM, Derrick Brashear <shadow@gmail.com> wrote:
> On Tue, Apr 13, 2010 at 1:45 PM, Jeffrey Altman
> <jaltman@secure-endpoints.com> wrote:
>> Prior to the release of OpenAFS, IBM/Transarc changed the name of the
>> struct nvldbentry field "spares1" to "matchindex".  They failed to
>> rename the equivalent struct uvldbentry field even though it is used for
>> the same purpose.   The inherited src/vlserver/vldbint.xg file even has
>> the following comment in the struct uvldbentry.
>>
>>   afs_int32       spares1;                        /* The server index
>> we matched */
>>
>> This e-mail is a formal request for a rename of this field in the
>> registry.  A patchset to OpenAFS has been submitted for this change as
>> http://gerrit.openafs.org/#change,1741.
>
> I concur, on the principal of "name it what it does"
>



-- 
Derrick



More information about the AFS3-standardization mailing list