[AFS3-std] struct uvldbentry field spares1 -> matchindex

[Jeffrey Hutzelman]

--On Tuesday, April 13, 2010 03:54:00 PM -0400 Derrick Brashear 
<shadow@gmail.com> wrote:

> Oh crap. The registrar was a real CC and not a BCC. Sorry.

Oops.  Well, this is what ticket merging is for.

> On Tue, Apr 13, 2010 at 3:53 PM, Derrick Brashear <shadow@gmail.com>
> wrote:
>> On Tue, Apr 13, 2010 at 1:45 PM, Jeffrey Altman
>> <jaltman@secure-endpoints.com> wrote:
>>> Prior to the release of OpenAFS, IBM/Transarc changed the name of the
>>> struct nvldbentry field "spares1" to "matchindex".  They failed to
>>> rename the equivalent struct uvldbentry field even though it is used for
>>> the same purpose.   The inherited src/vlserver/vldbint.xg file even has
>>> the following comment in the struct uvldbentry.
>>>
>>>   afs_int32       spares1;                        /*
>>> The server index we matched */
>>>
>>> This e-mail is a formal request for a rename of this field in the
>>> registry.  A patchset to OpenAFS has been submitted for this change as
>>> http://gerrit.openafs.org/#change,1741.
>>
>> I concur, on the principal of "name it what it does"

I agree with the change.

It's not clear to me that the registrar currently maintains this level of 
detail.  We'd certainly like to provide freely-reusable .xg files for the 
afs3 RPC suites, but that project hasn't really got off the ground, and 
there are licensing issues.

-- Jeff