[OpenAFS] 1.3.70 comments?

[Rainer Toebbicke]

On Tue, 2004-08-17 at 05:45, Derrick J Brashear wrote:
> I notice the comments aren't rolling in on this release. We need feedback 
> to fix remaining issues so 1.4 can be released. Is anyone actually using 
> this?
> 

Just started the first server/client combo and ran into the following
problems:

. fstrace hangs the machine almost immediately after 'fstrace setset cm
-act'. This is on an SMP i386 Linux 2.4.21-15.0.3.EL. It did the same
BTW on everything after Openafs 1.2.6 that I tested.

. afs/LINUX/osi_vnodeops.c uses the page_count macro which on that
system is defined in mm_inline.h which is not included (since there are
plenty of distributions without this file). The (brutal) fix is  

*** openafs/src/afs/LINUX/osi_vnodeops.c.0rig   2004-07-22
00:23:38.000000000 +0200
--- openafs/src/afs/LINUX/osi_vnodeops.c        2004-08-16
12:20:59.000000000 +0200
***************
*** 29,34 ****
--- 29,37 ----
  #include "afs/afs_stats.h"
  #include "afs/afs_osidnlc.h"
  #include "h/mm.h"
+ #if !defined(page_count)
+ #include "h/mm_inline.h"
+ #endif
  #include "h/pagemap.h"
  #if defined(AFS_LINUX24_ENV)
  #include "h/smp_lock.h"

...but ideally 'configure' should sort that out.

. src/butc/tcprocs.c re-defines a number of XBSA-related variables
already defined in .../tcmain.c. Does not build on Linux when 'xbsa' is
defined.

Cheers, Rainer
-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Rainer Toebbicke 
European Laboratory for Particle Physics(CERN) - Geneva, Switzerland  
Phone: +41 22 767 8985       Fax: +41 22 767 7155